Update primitive matching to consider all inputs

[thehomebrewnerd]

Update primitive matching to consider all inputs

Closes #1828

[codecov]

Codecov Report

Merging #2019 (7416caf) into main (7028210) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2019      +/-   ##
==========================================
+ Coverage   99.09%   99.10%   +0.01%     
==========================================
  Files         143      143              
  Lines       16511    16586      +75     
==========================================
+ Hits        16361    16438      +77     
+ Misses        150      148       -2     

Impacted Files	Coverage Δ
featuretools/feature_base/feature_base.py	96.89% <100.00%> (+0.01%)	⬆️
...aturetools/primitives/standard/binary_transform.py	100.00% <100.00%> (ø)
featuretools/synthesis/deep_feature_synthesis.py	98.62% <100.00%> (-0.01%)	⬇️
...s/tests/primitive_tests/test_transform_features.py	99.86% <100.00%> (+<0.01%)	⬆️
...ols/tests/synthesis/test_deep_feature_synthesis.py	99.34% <100.00%> (+0.01%)	⬆️
...ools/primitives/standard/aggregation_primitives.py	97.16% <0.00%> (+0.56%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb0e420...7416caf. Read the comment docs.

[thehomebrewnerd]

When testing this change, two new issues were discovered that can cause feature value calculation to fail in some cases. These two issues were not caused by this change and are documented in #2020 and #2021.

Previous to this PR, users would have had to manually define the features in order for these bugs to show up, but with this PR, DFS could potentially generate features that could not be calculated without error.

[rwedge]

Do you think we should have an alert of some kind in the release notes about the number of features created by DFS potentially changing?

[thehomebrewnerd]

Do you think we should have an alert of some kind in the release notes about the number of features created by DFS potentially changing?

Sounds like a good idea. I'll add that.

[thehomebrewnerd]

Do you think we should have an alert of some kind in the release notes about the number of features created by DFS potentially changing?

Sounds like a good idea. I'll add that.

@rwedge Added a note in the release notes about number of features increasing in some cases with this change.

[dvreed77]

lgtm

[thehomebrewnerd]

I ran the ecommerce_many_features_test in the performance tests against this branch. Initially that test highlighted some problems because of new features that were generated that failed on computation. After merging in the PRs to fix those issues, the ecommerce_many_features_test performance test completes successfully. Results comparing this branch to current main are below:

[rwedge]

LGTM