Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle parquet serialization with last time index #204

merged 3 commits into from Aug 3, 2018


Copy link

@kmax12 kmax12 commented Aug 3, 2018

Handles cases where we are serializing an entityset with a last time index. Also added test

Fixes #202

Copy link

Codecov Report

Merging #204 into master will increase coverage by 0.05%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #204      +/-   ##
+ Coverage    93.3%   93.35%   +0.05%     
  Files          70       70              
  Lines        7734     7737       +3     
+ Hits         7216     7223       +7     
+ Misses        518      514       -4
Impacted Files Coverage Δ
featuretools/entityset/ 91.66% <ø> (+3.57%) ⬆️
featuretools/tests/entityset_tests/ 99.31% <90%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e098d7...26a3d9a. Read the comment docs.

Copy link

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kmax12 kmax12 merged commit 6393fa9 into master Aug 3, 2018
@kmax12 kmax12 deleted the parquet_lti_serialization branch August 15, 2018 23:02
@rwedge rwedge mentioned this pull request Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants