Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Month primitives #2121

Merged
merged 7 commits into from Jun 21, 2022
Merged

Adding Month primitives #2121

merged 7 commits into from Jun 21, 2022

Conversation

sbadithe
Copy link
Contributor

@sbadithe sbadithe commented Jun 17, 2022 •
edited

Adding the following primitives:

gsheni
gsheni reviewed Jun 17, 2022
View reviewed changes
docs/source/release_notes.rst Outdated
@@ -6,7 +6,8 @@ Release Notes
Future Release
==============
* Enhancements
* Add ``DayOfYear``, ``DaysInMonth``, ``Quarter`` , ``IsLeapYear`` , ``IsQuarterEnd`` , ``IsQuarterStart`` transform primitives (:pr:`2110`, :pr:`2117`)
* Add ``DayOfYear``, ``DaysInMonth``, ``Quarter`` , ``IsLeapYear`` , ``IsQuarterEnd`` ,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can separate this in 2-3 lines. My suggestion was to just not do 1 primitive per line.

@codecov
Copy link

codecov bot commented Jun 17, 2022 •
edited

Codecov Report

Merging #2121 (5c0f2d6) into main (2272d70) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2121   +/-   ##
=======================================
  Coverage   99.20%   99.21%           
=======================================
  Files         143      143           
  Lines       16696    16728   +32     
=======================================
+ Hits        16564    16596   +32     
  Misses        132      132
Impacted Files Coverage Δ
...imitives/standard/datetime_transform_primitives.py 100.00% <100.00%> (ø)
.../tests/primitive_tests/test_transform_primitive.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2272d70...5c0f2d6. Read the comment docs.

@gsheni gsheni changed the title Adding month primitives Adding Month primitives Jun 17, 2022
gsheni
gsheni previously approved these changes Jun 18, 2022
View reviewed changes
@sbadithe sbadithe marked this pull request as ready for review June 21, 2022 18:30
dvreed77
dvreed77 approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@dvreed77 dvreed77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sbadithe sbadithe merged commit 210741d into main Jun 21, 2022
@sbadithe sbadithe deleted the adding-month-primitives branch June 21, 2022 22:10
@sbadithe sbadithe mentioned this pull request Jun 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvreed77 dvreed77 dvreed77 approved these changes

@gsheni gsheni gsheni left review comments

Assignees

@sbadithe sbadithe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add IsMonthEnd primitive Add IsMonthStart primitive
3 participants
@sbadithe @dvreed77 @gsheni