Entity Normalization Preserves Types of Copy & Additional Variables #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where variables with specific types (that are different from what would ordinarily be inferred) don't have their types carried over to a new entity upon normalization.
Say you have an entity with an Ordinal variable that is a numeric dtype under the hood, so the dataframe looks like {'ordered_values': [1,2,3]}. Then you normalize out an entity, flagging that variable to move or copy:
es.normalize_entity(base_entity, new_entity, additional_vars=['ordered_values'])
es.normalize_entity(base_entity, new_entity, copy_vars=['ordered_values'])
Before this fix, the
ordered_values
variable type innew_entity
would beNumeric
instead ofOrdinal
.