Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code refactoring #2607

Merged
merged 6 commits into from Sep 6, 2023
Merged

Code refactoring #2607

merged 6 commits into from Sep 6, 2023

Conversation

tosemml
Copy link
Contributor

@tosemml tosemml commented Sep 5, 2023

Pull Request Description

These slight code adjustments aim to enhance Pythonic quality by incorporating python list comprehension

Closes #2612

@CLAassistant
Copy link

CLAassistant commented Sep 5, 2023

CLA assistant check
All committers have signed the CLA.

@thehomebrewnerd
Copy link
Contributor

@tosemml Thank you for the contribution. Please update your branch with the latest changes from main, and that should allow the failing CI tests to pass.

Also please update the Future Release section in the docs/source/release_notes.rst file to add a brief description of your change in the "Changes" section and add your GitHub user name to the list of contributors in that file.

@tosemml
Copy link
Contributor Author

tosemml commented Sep 6, 2023

Done. Thanks

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (f359766) 99.47% compared to head (10d1b88) 99.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2607      +/-   ##
==========================================
- Coverage   99.47%   99.47%   -0.01%     
==========================================
  Files         403      403              
  Lines       24203    24201       -2     
==========================================
- Hits        24076    24074       -2     
  Misses        127      127              
Files Changed Coverage Δ
featuretools/tests/primitive_tests/utils.py 98.87% <100.00%> (-0.03%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehomebrewnerd thehomebrewnerd merged commit 924e928 into alteryx:main Sep 6, 2023
51 of 52 checks passed
@thehomebrewnerd thehomebrewnerd mentioned this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor utils.py to use list comprehension
3 participants