Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename NUnique to NumUnique #510

Merged
merged 7 commits into from Apr 29, 2019
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/source/api_reference.rst
Expand Up @@ -100,7 +100,7 @@ Aggregation Primitives
AvgTimeBetween
TimeSinceLast
TimeSinceFirst
NUnique
NumUnique
PercentTrue
All
Any
Expand Down
17 changes: 17 additions & 0 deletions docs/source/changelog.rst
@@ -1,5 +1,22 @@
.. _changelog:
**v0.8.0** Upcoming

**Breaking Changes**

* ``NUnique`` has been renamed to ``NumUnique``.

Previous behavior

.. code-block:: python

from featuretools.primitives import NUnique

New behavior

.. code-block:: python

from featuretools.primitives import NumUnique

Changelog
---------
**v0.7.1** Apr 24, 2019
Expand Down
4 changes: 2 additions & 2 deletions featuretools/primitives/standard/aggregation_primitives.py
Expand Up @@ -170,11 +170,11 @@ def get_function(self):
return np.max


class NUnique(AggregationPrimitive):
class NumUnique(AggregationPrimitive):
"""Determines the number of distinct values, ignoring `NaN` values.

Examples:
>>> num_unique = NUnique()
>>> num_unique = NumUnique()
>>> num_unique(['red', 'blue', 'green', 'yellow'])
4

Expand Down
2 changes: 1 addition & 1 deletion featuretools/synthesis/deep_feature_synthesis.py
Expand Up @@ -134,7 +134,7 @@ def __init__(self,
if agg_primitives is None:
agg_primitives = [primitives.Sum, primitives.Std, primitives.Max, primitives.Skew,
primitives.Min, primitives.Mean, primitives.Count,
primitives.PercentTrue, primitives.NUnique, primitives.Mode]
primitives.PercentTrue, primitives.NumUnique, primitives.Mode]
self.agg_primitives = []
agg_prim_dict = primitives.get_aggregation_primitives()
for a in agg_primitives:
Expand Down