Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates TimeSincePrevious and Diff Primitives #561

Merged
merged 17 commits into from May 23, 2019
Merged

Updates TimeSincePrevious and Diff Primitives #561

merged 17 commits into from May 23, 2019

Conversation

ctduffy
Copy link
Contributor

@ctduffy ctduffy commented May 23, 2019

fixes #501

@ctduffy ctduffy requested a review from rwedge May 23, 2019 15:02
@codecov
Copy link

codecov bot commented May 23, 2019

Codecov Report

Merging #561 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #561      +/-   ##
==========================================
- Coverage   96.36%   96.35%   -0.01%     
==========================================
  Files         116      116              
  Lines        9262     9244      -18     
==========================================
- Hits         8925     8907      -18     
  Misses        337      337
Impacted Files Coverage Δ
...s/tests/primitive_tests/test_transform_features.py 98.31% <100%> (ø) ⬆️
...turetools/computational_backends/pandas_backend.py 98.06% <100%> (-0.02%) ⬇️
...ols/tests/dfs_tests/test_deep_feature_synthesis.py 100% <100%> (ø) ⬆️
...retools/primitives/standard/transform_primitive.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c139527...f644e22. Read the comment docs.

Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, the tests that used Diff / TimeSincePrevious should use GroupByTransformFeature so that we do not need to change the test answers.

featuretools/primitives/standard/transform_primitive.py Outdated Show resolved Hide resolved
featuretools/primitives/standard/transform_primitive.py Outdated Show resolved Hide resolved
featuretools/primitives/standard/transform_primitive.py Outdated Show resolved Hide resolved
@ctduffy
Copy link
Contributor Author

ctduffy commented May 23, 2019

fixed issues brought up by @rwedge

@ctduffy
Copy link
Contributor Author

ctduffy commented May 23, 2019

@rwedge fixed test cases

rwedge
rwedge previously approved these changes May 23, 2019
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kmax12 kmax12 self-requested a review May 23, 2019 19:27
@ctduffy
Copy link
Contributor Author

ctduffy commented May 23, 2019

@kmax12 fixed the timesinceprevious units and removed the diff date example

Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ctduffy ctduffy merged commit 0fc1c00 into master May 23, 2019
@ctduffy ctduffy deleted the issue501 branch May 23, 2019 19:49
@rwedge rwedge mentioned this pull request Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Time Since Previous and Diff primitives
3 participants