Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Timedelta data param #619

Merged
merged 4 commits into from Jun 21, 2019
Merged

Remove Timedelta data param #619

merged 4 commits into from Jun 21, 2019

Conversation

CJStadler
Copy link
Contributor

Constructing a Timedelta with data via __call__ was removed in #572 ,
so this is no longer used.

Resolves #592

Constructing a Timedelta with data via __call__ was removed in 3b84b66,
so this is no longer used.
@codecov
Copy link

codecov bot commented Jun 21, 2019

Codecov Report

Merging #619 into master will increase coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #619      +/-   ##
==========================================
+ Coverage   97.27%   97.42%   +0.15%     
==========================================
  Files         118      118              
  Lines        9545     9526      -19     
==========================================
- Hits         9285     9281       -4     
+ Misses        260      245      -15
Impacted Files Coverage Δ
featuretools/exceptions.py 66.66% <ø> (ø) ⬆️
featuretools/entityset/timedelta.py 87.2% <100%> (+8.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 321a0f4...cce43e7. Read the comment docs.

Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CJStadler CJStadler merged commit f51d883 into master Jun 21, 2019
@CJStadler CJStadler deleted the remove-timedelta-data branch June 21, 2019 16:56
@rwedge rwedge mentioned this pull request Jul 3, 2019
johnnyheineken pushed a commit to johnnyheineken/featuretools that referenced this pull request Jul 7, 2019
Constructing a Timedelta with data via __call__ was removed in 3b84b66,
so this is no longer used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Timedelta data param
2 participants