fixed hash issue with same base features

featuretools/primitives/binary_transform.py

@@ -24,7 +24,9 @@ def __init__(self, left, right):
 
         self._right_index = -1
         if isinstance(right, PrimitiveBase):
-            base_features.append(right)
+            if (not isinstance(left, PrimitiveBase) or
+                    right.hash() != self.left.hash()):
+                base_features.append(right)
             self.right = right
         else:
             self.right = right

featuretools/tests/computational_backend/test_pandas_backend.py

@@ -444,3 +444,13 @@ def test_topn(entityset, backend):
     for i, values in enumerate(df[topn.get_name()].values):
         for j, v in enumerate(values):
             assert (v == true_results[i][j])
+
+
+def test_direct_squared(entityset, backend):
+    feature = IdentityFeature(entityset['log']['value'])
+    squared = feature * feature
+    pandas_backend = backend([feature, squared])
+    df = pandas_backend.calculate_all_features(instance_ids=[0, 1, 2],
+                                               time_last=None)
+    for i, row in df.iterrows():
+        assert (row[0] * row[0]) == row[1]

featuretools/tests/feature_function_tests/test_direct_features.py

@@ -39,4 +39,4 @@ def test_direct_rename(es):
     assert feat.hash() != copy_feat.hash()
     assert feat.get_name() != copy_feat.get_name()
     assert feat.base_features[0]._get_name() == copy_feat.base_features[0]._get_name()
-    assert feat.entity == copy_feat.entity
+    assert feat.entity == copy_feat.entity

featuretools/tests/feature_function_tests/test_primitive_base.py

@@ -70,3 +70,10 @@ def test_get_depth(es):
     assert d2.get_depth(stop_at=[f, g, agg2]) == 2
     assert d2.get_depth(stop_at=[f, g, d1]) == 1
     assert d2.get_depth(stop_at=[f, g, d2]) == 0
+
+
+def test_squared(es):
+    feature = Feature(es['log']['value'])
+    squared = feature * feature
+    assert len(squared.base_features) == 1
+    assert squared.base_features[0].hash() == feature.hash()