Fix build_docs test#803
Merged
Merged
Conversation
kmax12
approved these changes
Nov 8, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Resolves #802
Importing
featuretools.autonormalizefails seemingly due to pip not installing a version of python-dateutil that satisfies both pandas and botocore.Once boto/botocore#1872 is resolved we can remove the requirement
We could add more automated tests checking that
featuretools.autonormalizeand other entrypoint imports work, but I think it would be better to test those on the original library's repo instead of ours.I'm thinking a test scheme like this:
featuretools[complete]install the additional libraryAfter creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of
docs/source/changelog.rstto include this pull request.