Skip to content

Pin msgpack for Python 3.5 - #851

Merged
frances-h merged 2 commits into
masterfrom
pin-msgpack
Feb 24, 2020
Merged

Pin msgpack for Python 3.5#851
frances-h merged 2 commits into
masterfrom
pin-msgpack

Conversation

@frances-h

@frances-h frances-h commented Feb 24, 2020

Copy link
Copy Markdown
Contributor

Dask distributed runs into issues with the msgpack 1.0.0 release on Python 3.5. Dask no longer supports Python 3.5, so their fix for the msgpack update does not get applied to Python 3.5. This pins msgpack to before the 1.0.0 release on Python 3.5 to avoid the issue.

Dask distributed required dataframe dependencies for a check where the full dependency was not needed. Dask has updated, so the additional dataframe dependencies are no longer required for distributed to work correctly with Featuretools

@frances-h
frances-h requested a review from rwedge February 24, 2020 19:06
@rwedge

rwedge commented Feb 24, 2020

Copy link
Copy Markdown
Contributor

Can you add this to the changelog?

@codecov-io

codecov-io commented Feb 24, 2020

Copy link
Copy Markdown

Codecov Report

Merging #851 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #851   +/-   ##
=======================================
  Coverage   98.14%   98.14%           
=======================================
  Files         117      117           
  Lines       10812    10812           
=======================================
  Hits        10611    10611           
  Misses        201      201

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dcafc2...5f81cac. Read the comment docs.

@rwedge rwedge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@frances-h
frances-h merged commit 46d025c into master Feb 24, 2020
@frances-h
frances-h deleted the pin-msgpack branch February 24, 2020 20:25
@rwedge rwedge mentioned this pull request Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants