Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin msgpack for Python 3.5 #851

Merged
merged 2 commits into from Feb 24, 2020
Merged

Pin msgpack for Python 3.5 #851

merged 2 commits into from Feb 24, 2020

Conversation

frances-h
Copy link
Contributor

@frances-h frances-h commented Feb 24, 2020

Dask distributed runs into issues with the msgpack 1.0.0 release on Python 3.5. Dask no longer supports Python 3.5, so their fix for the msgpack update does not get applied to Python 3.5. This pins msgpack to before the 1.0.0 release on Python 3.5 to avoid the issue.

Dask distributed required dataframe dependencies for a check where the full dependency was not needed. Dask has updated, so the additional dataframe dependencies are no longer required for distributed to work correctly with Featuretools

@rwedge
Copy link
Contributor

rwedge commented Feb 24, 2020

Can you add this to the changelog?

@codecov-io
Copy link

codecov-io commented Feb 24, 2020

Codecov Report

Merging #851 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #851   +/-   ##
=======================================
  Coverage   98.14%   98.14%           
=======================================
  Files         117      117           
  Lines       10812    10812           
=======================================
  Hits        10611    10611           
  Misses        201      201

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dcafc2...5f81cac. Read the comment docs.

Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@frances-h frances-h merged commit 46d025c into master Feb 24, 2020
@frances-h frances-h deleted the pin-msgpack branch February 24, 2020 20:25
@rwedge rwedge mentioned this pull request Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants