Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.5 support #917

Merged
merged 4 commits into from Apr 17, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 0 additions & 19 deletions .circleci/config.yml
Expand Up @@ -234,28 +234,17 @@ workflows:
version: 2
test_all_python_versions:
jobs:
- win_unit_tests:
name: "py35 windows unit tests"
python_version: "3.5"
- win_unit_tests:
name: "py36 windows unit tests"
python_version: "3.6"
- win_unit_tests:
name: "py37 windows unit tests"
python_version: "3.7"
- install_ft:
name: "py35 install featuretools"
image_tag: "3.5"
- install_ft:
name: "py36 install featuretools"
image_tag: "3.6"
- install_ft:
name: "py37 install featuretools"
- unit_tests:
name: "py35 unit tests"
image_tag: "3.5"
requires:
- "py35 install featuretools"
- unit_tests:
name: "py36 unit tests"
image_tag: "3.6"
Expand All @@ -266,11 +255,6 @@ workflows:
name: "py37 unit tests"
requires:
- "py37 install featuretools"
- lint_test:
name: "py35 lint test"
image_tag: "3.5"
requires:
- "py35 install featuretools"
- lint_test:
name: "py36 lint test"
image_tag: "3.6"
Expand All @@ -284,9 +268,6 @@ workflows:
name: "build docs"
requires:
- "py37 install featuretools"
- install_ft_complete:
name: "py35 install featuretools complete test"
image_tag: "3.5"
- install_ft_complete:
name: "py36 install featuretools complete test"
image_tag: "3.6"
Expand Down
1 change: 1 addition & 0 deletions docs/source/changelog.rst
Expand Up @@ -8,6 +8,7 @@ Changelog
* Fixes
* Use logger.warning to fix deprecated logger.warn (:pr:`871`)
* Changes
* Remove Python 3.5 support (:pr:`917`)
* Documentation Changes
* Fix README links to docs (:pr:`872`)
* Fix Github links with correct organizations (:pr:`908`)
Expand Down
2 changes: 1 addition & 1 deletion docs/source/getting_started/install.rst
@@ -1,7 +1,7 @@
Install
*******

Featuretools is available for Python 3.5, 3.6 and 3.7 The recommended way to install Featuretools is using ``pip`` or ``conda``::
Featuretools is available for Python 3.6 and 3.7. The recommended way to install Featuretools is using ``pip`` or ``conda``::

python -m pip install featuretools

Expand Down
Expand Up @@ -200,7 +200,6 @@ def test_s3_test_profile(es, s3_client, s3_bucket, setup_test_profile):

@pytest.mark.parametrize("url,profile_name", [(S3_URL, None), (S3_URL, False), (URL, None)])
def test_deserialize_features_s3(es, url, profile_name):
# TODO: Feature ordering is different in py3.5 vs 3.6+
features_original = sorted(ft.dfs(target_entity='sessions', entityset=es, features_only=True), key=lambda x: x.unique_name())
features_deserialized = sorted(ft.load_features(url, profile_name=profile_name), key=lambda x: x.unique_name())
assert_features(features_original, features_deserialized)
Expand Down
1 change: 0 additions & 1 deletion requirements.txt
Expand Up @@ -8,4 +8,3 @@ distributed>=1.24.2
dask>=1.1.0
psutil>=5.4.8
click>=7.0.0
msgpack<1.0.0; python_version == '3.5'
3 changes: 1 addition & 2 deletions setup.py
Expand Up @@ -29,12 +29,11 @@
'Development Status :: 3 - Alpha',
'Intended Audience :: Developers',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7'
],
install_requires=open('requirements.txt').readlines(),
python_requires='>=3.5, <4',
python_requires='>=3.6, <4',
extras_require=extras_require,
keywords='feature engineering data science machine learning',
include_package_data=True,
Expand Down