Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of pd.datetime #998

Merged
merged 5 commits into from May 27, 2020
Merged

Remove use of pd.datetime #998

merged 5 commits into from May 27, 2020

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented May 27, 2020

@gsheni gsheni self-assigned this May 27, 2020
@gsheni gsheni requested a review from rwedge May 27, 2020 14:52
@codecov
Copy link

codecov bot commented May 27, 2020 •
edited

Codecov Report

Merging #998 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #998   +/-   ##
=======================================
  Coverage   98.25%   98.25%           
=======================================
  Files         119      119           
  Lines       11030    11030           
=======================================
  Hits        10838    10838           
  Misses        192      192
Impacted Files Coverage Δ
...computational_backends/calculate_feature_matrix.py 98.61% <ø> (ø)
featuretools/entityset/entity.py 95.78% <ø> (ø)
...utational_backend/test_calculate_feature_matrix.py 99.42% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8d42c4...642c9a8. Read the comment docs.

@tuethan1999 tuethan1999 changed the title Remove use of pd.dateime Remove use of pd.datetime May 27, 2020
rwedge
rwedge reviewed May 27, 2020
View reviewed changes
docs/source/changelog.rst Outdated Show resolved Hide resolved
rwedge
rwedge approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@gsheni gsheni merged commit d502e75 into master May 27, 2020
@gsheni gsheni deleted the remove_pddatetime branch May 27, 2020 20:11
@rwedge rwedge mentioned this pull request May 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwedge rwedge rwedge approved these changes

Assignees

@gsheni gsheni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove pd.datetime, use datetime module instead
2 participants
@gsheni @rwedge