Conditionally add tensorflow dependent primitives to top level primitives #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwedge
force-pushed
the
conditionally-load-USE
branch
from
3c25311
to
53373a7
Compare
rwedge
changed the title
Comment on lines
+31
to
+32
| def test_name_in_primitive_list(universal_sentence_encoder): | ||
| assert PRIMITIVES.name.eq(universal_sentence_encoder.name).any() |
There was a problem hiding this comment.
Any reason to add a similar test for Elmo?
There was a problem hiding this comment.
The Elmo tests use the PrimitiveT test class so there should already be a test like that for Elmo
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses importlib to check for a tensorflow module before adding
UniversalSentenceEncoderandElmoto top level imports for the library