Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use authenticated docker pulls for Circle CI #44

Merged
merged 3 commits into from
Nov 2, 2020
Merged

Use authenticated docker pulls for Circle CI #44

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eefb700
use job matrices for circleci config
rwedge Nov 2, 2020
ddb4851
fix image_tag parameter syntax
rwedge Nov 2, 2020
9c72e8b
add dockerhub authentication
rwedge Nov 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 24 additions & 33 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@ executors:
type: string
default: "python:3.8"
docker:
- image: circleci/<< parameters.image_tag >>
- image: circleci/python:<< parameters.image_tag >>
auth:
username: $DOCKERHUB_USERNAME
password: $DOCKERHUB_PASSWORD
resource_class: large

commands:
Expand Down Expand Up @@ -130,40 +133,28 @@ workflows:
"Integration Tests":
jobs:
- lint_tests:
name: "Lint Tests - Python 3.6"
image_tag: "python:3.6"
- lint_tests:
name: "Lint Tests - Python 3.7"
image_tag: "python:3.7"
- lint_tests:
name: "Lint Tests - Python 3.8"
image_tag: "python:3.8"
- unit_tests:
name: "Unit Tests - Python 3.6"
image_tag: "python:3.6"
- unit_tests:
name: "Unit Tests - Python 3.7"
image_tag: "python:3.7"
matrix:
parameters:
image_tag: ["3.6", "3.7", "3.8"]
name: << matrix.image_tag >> lint tests
context: dockerhub
- unit_tests:
name: "Unit Tests - Python 3.8"
image_tag: "python:3.8"
matrix:
parameters:
image_tag: ["3.6", "3.7", "3.8"]
name: << matrix.image_tag >> unit tests
context: dockerhub
"Packaging Tests":
jobs:
- entry_point_test:
name: "Entry Point Test - Python 3.6"
image_tag: "python:3.6"
- entry_point_test:
name: "Entry Point Test - Python 3.7"
image_tag: "python:3.7"
- entry_point_test:
name: "Entry Point Test - Python 3.8"
image_tag: "python:3.8"
- package_test:
name: "Packaging Test - Python 3.6"
image_tag: "python:3.6"
- package_test:
name: "Packaging Test - Python 3.7"
image_tag: "python:3.7"
matrix:
parameters:
image_tag: ["3.6", "3.7", "3.8"]
name: << matrix.image_tag >> entry point test
context: dockerhub
- package_test:
name: "Packaging Test - Python 3.8"
image_tag: "python:3.8"
matrix:
parameters:
image_tag: ["3.6", "3.7", "3.8"]
name: << matrix.image_tag >> package tests
context: dockerhub