Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NumUniqueSeparators primitive #90

Merged
merged 10 commits into from
Jan 12, 2022
Merged

Add NumUniqueSeparators primitive #90

merged 10 commits into from
Jan 12, 2022

Conversation

tuethan1999
Copy link
Contributor

@tuethan1999 tuethan1999 commented Jan 3, 2022 •
edited by gsheni
Loading

Fixes #78

@tuethan1999 tuethan1999 changed the title Add num unique separators primitive Add NumUniqueSeparators primitive Jan 3, 2022
@gsheni gsheni requested a review from a team January 5, 2022 15:13
rwedge
rwedge reviewed Jan 5, 2022
View reviewed changes
nlp_primitives/num_unique_separators.py Outdated Show resolved Hide resolved
nlp_primitives/num_unique_separators.py Outdated Show resolved Hide resolved
nlp_primitives/num_unique_separators.py Outdated Show resolved Hide resolved
tamargrey
tamargrey previously approved these changes Jan 10, 2022
View reviewed changes
Copy link

@tamargrey tamargrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tuethan1999 tuethan1999 enabled auto-merge (squash) January 10, 2022 19:12
@tuethan1999 tuethan1999 merged commit 7b994b7 into main Jan 12, 2022
@gsheni gsheni deleted the num_unique_separators branch January 12, 2022 21:28
@dvreed77 dvreed77 mentioned this pull request Feb 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwedge rwedge rwedge left review comments

@gsheni gsheni gsheni approved these changes

@tamargrey tamargrey tamargrey left review comments

Assignees

@tuethan1999 tuethan1999

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add NumUniqueSeparators primitive
4 participants
@tuethan1999 @rwedge @gsheni @tamargrey