New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise type conversion error in datetime #1001
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1001 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 46 46
Lines 7639 7655 +16
=========================================
+ Hits 7639 7655 +16
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small suggestion, but otherwise looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Closes #991 by raising a type conversion error when a Datetime logical type cannot parse data to a datetime dtype.