Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise type conversion error in datetime #1001

Merged
merged 8 commits into from Jun 22, 2021
Merged

Conversation

jeff-hernandez
Copy link
Contributor

Closes #991 by raising a type conversion error when a Datetime logical type cannot parse data to a datetime dtype.

@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #1001 (3c83848) into main (950562d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1001   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           46        46           
  Lines         7639      7655   +16     
=========================================
+ Hits          7639      7655   +16     
Impacted Files Coverage Δ
woodwork/exceptions.py 100.00% <100.00%> (ø)
woodwork/logical_types.py 100.00% <100.00%> (ø)
woodwork/tests/logical_types/test_logical_types.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 950562d...3c83848. Read the comment docs.

@jeff-hernandez jeff-hernandez marked this pull request as ready for review June 21, 2021 16:44
Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion, but otherwise looks good to me.

woodwork/tests/logical_types/test_logical_types.py Outdated Show resolved Hide resolved
Copy link
Contributor

@tamargrey tamargrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jeff-hernandez jeff-hernandez merged commit da08022 into main Jun 22, 2021
@jeff-hernandez jeff-hernandez deleted the update_datetime_transform branch June 22, 2021 14:02
@tamargrey tamargrey mentioned this pull request Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datetime logical type transform does not throw TypeConversionError
3 participants