Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle large range in extra stats #1287

Merged
merged 3 commits into from Feb 8, 2022
Merged

Handle large range in extra stats #1287

merged 3 commits into from Feb 8, 2022

Conversation

tamargrey
Copy link
Contributor

  • There are situations where the range between a column's min and max value is so large that len(range(min, max)) produces an OverflowError, so we're changing the call in describe_dict's extra stats to just subtract max + 1 - min.

@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #1287 (2825fca) into main (f20f135) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1287   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files          49       49           
  Lines        8929     8942   +13     
=======================================
+ Hits         8925     8938   +13     
  Misses          4        4           
Impacted Files Coverage Δ
woodwork/statistics_utils.py 100.00% <100.00%> (ø)
woodwork/tests/accessor/test_statistics.py 99.35% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f20f135...2825fca. Read the comment docs.

Copy link
Contributor

@dvreed77 dvreed77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tamargrey tamargrey merged commit 25ecde8 into main Feb 8, 2022
@tamargrey tamargrey deleted the describe-overflow branch February 8, 2022 16:34
@jeff-hernandez jeff-hernandez mentioned this pull request Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants