Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IsNaturalLanguage property to ColumnSchema #1610

Merged
merged 7 commits into from Jan 10, 2023
Merged

Add IsNaturalLanguage property to ColumnSchema #1610

merged 7 commits into from Jan 10, 2023

Conversation

sbadithe
Copy link
Contributor

@sbadithe sbadithe commented Jan 6, 2023 •
edited

This property could potentially be used in a featuretools utility

@sbadithe sbadithe changed the title Add IsNaturalLanguage property to ColumnSchema Add IsNaturalLanguage property to ColumnSchema Jan 6, 2023
@codecov
Copy link

codecov bot commented Jan 6, 2023 •
edited

Codecov Report

Merging #1610 (bc5f225) into main (7932523) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1610   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files          98       98           
  Lines       11582    11596   +14     
=======================================
+ Hits        11440    11454   +14     
  Misses        142      142
Impacted Files Coverage Δ
woodwork/column_schema.py 100.00% <100.00%> (ø)
woodwork/tests/schema/test_column_schema.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sbadithe sbadithe marked this pull request as ready for review January 6, 2023 20:23
ParthivNaresh
ParthivNaresh reviewed Jan 10, 2023
View reviewed changes
Copy link
Collaborator

@ParthivNaresh ParthivNaresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a quick test for this in test_column_schema in the style of test_is_categorical, test_is_boolean, and test_is_datetime? Otherwise looks great!

ParthivNaresh
ParthivNaresh approved these changes Jan 10, 2023
View reviewed changes
Copy link
Collaborator

@ParthivNaresh ParthivNaresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbadithe sbadithe merged commit 1ff502a into main Jan 10, 2023
@sbadithe sbadithe deleted the add-is-natlang-test-to-columnschema branch January 10, 2023 21:43
@ParthivNaresh ParthivNaresh mentioned this pull request Jan 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ParthivNaresh ParthivNaresh ParthivNaresh approved these changes

Assignees

@sbadithe sbadithe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sbadithe @ParthivNaresh