Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python 3.11 markers, add 3.11 for unit tests & install test #1678

Merged
merged 10 commits into from Apr 17, 2023
Merged

Add Python 3.11 markers, add 3.11 for unit tests & install test #1678

merged 10 commits into from Apr 17, 2023

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Apr 17, 2023 •
edited

@gsheni gsheni changed the title Update install_test.yaml Add Python 3.11 markers, add 3.11 for unit tests & install test Apr 17, 2023
@gsheni gsheni self-assigned this Apr 17, 2023
@gsheni gsheni marked this pull request as ready for review April 17, 2023 14:30
@codecov
Copy link

codecov bot commented Apr 17, 2023 •
edited

Codecov Report

Merging #1678 (1a9d444) into main (a1bbfa9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1678   +/-   ##
=======================================
  Coverage   98.79%   98.79%           
=======================================
  Files          98       98           
  Lines       11800    11805    +5     
=======================================
+ Hits        11658    11663    +5     
  Misses        142      142
Impacted Files Coverage Δ
woodwork/tests/accessor/test_serialization.py 100.00% <ø> (ø)
woodwork/table_accessor.py 99.57% <100.00%> (+<0.01%) ⬆️
woodwork/tests/accessor/test_column_accessor.py 100.00% <100.00%> (ø)
woodwork/tests/conftest.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gsheni gsheni requested a review from a team April 17, 2023 16:44
ParthivNaresh
ParthivNaresh approved these changes Apr 17, 2023
View reviewed changes
Copy link
Collaborator

@ParthivNaresh ParthivNaresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

bchen1116
bchen1116 approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gsheni gsheni merged commit de5de7f into main Apr 17, 2023
37 checks passed
@gsheni gsheni deleted the py311 branch April 17, 2023 17:47
@ParthivNaresh ParthivNaresh mentioned this pull request May 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bchen1116 bchen1116 bchen1116 approved these changes

@ParthivNaresh ParthivNaresh ParthivNaresh approved these changes

Assignees

@gsheni gsheni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Python 3.11 support and unit tests
3 participants
@gsheni @bchen1116 @ParthivNaresh