Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update numpy to latest #1799

Merged
merged 48 commits into from
Feb 2, 2024
Merged

Update numpy to latest #1799

merged 48 commits into from
Feb 2, 2024

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Dec 18, 2023

Closes #1766

@gsheni gsheni self-assigned this Dec 18, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 18, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (47303d4) 98.78% compared to head (221c49a) 98.78%.
Report is 100 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1799      +/-   ##
==========================================
- Coverage   98.78%   98.78%   -0.01%     
==========================================
  Files          98       98              
  Lines       11728    11971     +243     
==========================================
+ Hits        11586    11826     +240     
- Misses        142      145       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CLAassistant
Copy link

CLAassistant commented Jan 22, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@cp2boston
Merge branch 'main' into update_numpy
24c3ded
@cp2boston
Add line to end of release notes
f8f3b47
@cp2boston
Missing blank line
f59074b 
In release notes
@cp2boston
Merge remote-tracking branch 'origin/integrate_string_arrow' into upd…
dc4ba5b 
…ate_numpy
@cp2boston
Revert "Merge remote-tracking branch 'origin/integrate_string_arrow' …
6c7ae95 
…into update_numpy"

This reverts commit dc4ba5b, reversing
changes made to f59074b.
@cp2boston
Doc updates, tests pass
c7cadce 
All tests pass with upgraded libs
@cp2boston
update min pyarrow in test reqs
3cf4e11 
Update the minimum pyarrow package in the test requirements
@cp2boston
moto.mock_s3 -> moto.mock_aws
509e50d 
name change in library
@cp2boston
Updated min req for moto
19759ec
@cp2boston
boto3 min updated
a37ed8a 
moto upgrade requires an upgrade to boto3
@cp2boston
parquet - try forcing INT96 timestamp
7dac3b1 
Workaround for the Minimum Dependencies (Spark) test
@cp2boston
Remove temp parquet file
92d1e4f 
Used for local manual test and slipped through
thehomebrewnerd
thehomebrewnerd reviewed Feb 2, 2024
View reviewed changes
Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are a few initial comments. I want to think a bit more about a few other changes before I comment further.

docs/source/install.md Outdated Show resolved Hide resolved
docs/source/release_notes.rst Outdated Show resolved Hide resolved
docs/source/release_notes.rst Outdated Show resolved Hide resolved
woodwork/tests/requirement_files/minimum_core_requirements.txt Outdated Show resolved Hide resolved
@thehomebrewnerd thehomebrewnerd mentioned this pull request Feb 2, 2024
Closed
@cp2boston cp2boston merged commit 98e4735 into main Feb 2, 2024
30 of 31 checks passed
@cp2boston cp2boston deleted the update_numpy branch February 2, 2024 22:16
@tamargrey tamargrey mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thehomebrewnerd thehomebrewnerd thehomebrewnerd approved these changes

@ParthivNaresh ParthivNaresh ParthivNaresh approved these changes

Assignees

@gsheni gsheni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Serialization is broken with pyarrow==13.0.0
5 participants
@gsheni @CLAassistant @thehomebrewnerd @ParthivNaresh @cp2boston