Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instantiated LogicalType bugs #231

Merged
merged 5 commits into from Oct 9, 2020
Merged

Conversation

tamargrey
Copy link
Contributor

@tamargrey tamargrey commented Oct 8, 2020

closes #230

  • Adds a utils function to just get the LogicalType class for any logical type whether it's instantiated or not
  • Fixes problem with checking if Datetime() is a class
    • fixes subclass issue in describe
    • fixes subclass issue in mutual info
    • fixes subclass issue in select (ignored select_ltypes and semantic tags bc they're bing removed)

@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #231 into main will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #231   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files          22       22           
  Lines        2270     2301   +31     
=======================================
+ Hits         2269     2300   +31     
  Misses          1        1           
Impacted Files Coverage Δ
woodwork/data_column.py 100.00% <100.00%> (ø)
woodwork/data_table.py 100.00% <100.00%> (ø)
woodwork/tests/data_table/test_datatable.py 100.00% <100.00%> (ø)
woodwork/utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72b9910...b464d70. Read the comment docs.

Copy link
Contributor

@gsheni gsheni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

woodwork/tests/data_table/test_datatable.py Show resolved Hide resolved
@tamargrey tamargrey merged commit 57fccfe into main Oct 9, 2020
@gsheni gsheni mentioned this pull request Oct 9, 2020
@gsheni gsheni deleted the fix-subclass-instance-check branch October 16, 2020 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checking issubclass breaks for instantiated LogicalTypes
2 participants