Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pyarrow from core dependencies #508

Merged
merged 4 commits into from Jan 25, 2021
Merged

Conversation

thehomebrewnerd
Copy link
Contributor

Moves pyarrow from requirements.txt to test-requirements.txt. Attempting to serialize to parquet without pyarrow installed will result in an ImportError with a message prompting the user to install pyarrow. Also adds a section to the Installation guide to list optional dependencies used by Woodwork.

@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

Merging #508 (7a9bdc5) into main (d298131) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #508   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        37           
  Lines         5101      5103    +2     
=========================================
+ Hits          5101      5103    +2     
Impacted Files Coverage Δ
woodwork/datatable.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d298131...7a9bdc5. Read the comment docs.

Copy link
Contributor

@gsheni gsheni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall. Just 1 minor doc suggestion.

docs/source/install.ipynb Show resolved Hide resolved
@thehomebrewnerd thehomebrewnerd merged commit 6d29b35 into main Jan 25, 2021
@thehomebrewnerd thehomebrewnerd deleted the optional-pyarrow branch January 25, 2021 21:15
@gsheni gsheni mentioned this pull request Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make pyarrow an optional installation
2 participants