Rename Accessor methods #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## schema-accessor #723 +/- ##
===================================================
Coverage ? 100.00%
===================================================
Files ? 46
Lines ? 6181
Branches ? 0
===================================================
Hits ? 6181
Misses ? 0
Partials ? 0 Continue to review full report at Codecov.
|
tamargrey
reviewed
Mar 18, 2021
thehomebrewnerd
approved these changes
Mar 18, 2021
gsheni
pushed a commit
that referenced
this pull request
Mar 22, 2021
* Add schema files * Create Schema class that holds typing info (#499) * Move over methods necessary for init * get basic init working * Add column dictionary to get type inference * cleanup tests * Move more passing tests to schema * fix semantic tags * Fix index and time_index * Allow underlying index to be set * Allow making index column - Koalas broken * Cleanup * Dont allow numpy init * Add repr to schema * add Schema equality check * lint fix * Separate tests into different files * Change dt useage to schema * Fix coverage * Additional column tests * Cleanup datatable usage * Clean up comments * Add release note * Remove dataframe from Schema and update validation checks * Update rest of schema class to stop using dataframe and start moving tests over * Update description and metadata tests * Change over rest of tests from dataframe useage * respond to PR comments * lint fix * Move column creation to it's own file * fix coverage * lint fix * PR comments * Only allow registered LogicalTypes in Schema * More pr comments * Fix release notes after rebase * Add release note * Create WoodworkTableAccessor class init and inspect (#514) * Create Schema class that holds typing info (#499) * Move over methods necessary for init * get basic init working * Add column dictionary to get type inference * cleanup tests * Move more passing tests to schema * fix semantic tags * Fix index and time_index * Allow underlying index to be set * Allow making index column - Koalas broken * Cleanup * Dont allow numpy init * Add repr to schema * add Schema equality check * lint fix * Separate tests into different files * Change dt useage to schema * Fix coverage * Additional column tests * Cleanup datatable usage * Clean up comments * Add release note * Remove dataframe from Schema and update validation checks * Update rest of schema class to stop using dataframe and start moving tests over * Update description and metadata tests * Change over rest of tests from dataframe useage * respond to PR comments * lint fix * Move column creation to it's own file * fix coverage * lint fix * PR comments * Only allow registered LogicalTypes in Schema * More pr comments * Fix release notes after rebase * Add accessor class that creates a schema with params * Add param validation * Add validation tests for accessor * Add getattribute to grab accessor and then schema attrs * Make index in dataframe * Add logical type parsing and inference * Update underlying data dtypes to match ltypes * Add underlying index and sort * Move tests to correct file * add time index and ltype tests * Add type inference tests * Cleanup and catch Attributes that arent present * add api reference and release note * Add init file to accessor test dir * Fix coverage, error for nonexistant attr, and test schema equality * Use getattr instead of getattribute on Accessor * fix coverage * PR comments * Add tests for ordinal and falsy names * check that referencing accessor attrs before schema init is ok * pr comments * More pr comments * Add docstring to init * Change set underlying index docstring * Allow initializing accessor with valid schema (#522) * add _is_valid_schema function * Allow schema passed in on init * Update schema validation to happen with param validation * Fix cverage and add release note * add read_csv_to_accessor that creates a DataFrame with the Schema initialized (#534) * Add read_csv_to_accessor util function * Add release note * Add ability to call DataFrame methods from Accessor (#538) * Add ability to call pandas methods from Accessor * Add more tests for pandas calls * Add erroring checks * Add Release note * Update docstring * Remove indexer test * Warn and set schema to None if inplace operation invalidates schema * Add specific error messages for invalid schemas * Add init info to warning * remove comments * Use warnings for any invalid schema at getattr * Clean up line lengths * Move getattr logic to helpers * PR comments * consolidate warnings * Add column helpers for checking if columns are of a certain type (#553) * Add four is type helpers * cleanup * Add release note * Load demo data with accessor (#556) * load retail data and return dataframe with accessor * Docstring updates * Add release note * lint fix * Add `select` to Accessor (#548) * Initial implementation of series accessor (#562) * Add schema files * Create Schema class that holds typing info (#499) * Move over methods necessary for init * get basic init working * Add column dictionary to get type inference * cleanup tests * Move more passing tests to schema * fix semantic tags * Fix index and time_index * Allow underlying index to be set * Allow making index column - Koalas broken * Cleanup * Dont allow numpy init * Add repr to schema * add Schema equality check * lint fix * Separate tests into different files * Change dt useage to schema * Fix coverage * Additional column tests * Cleanup datatable usage * Clean up comments * Add release note * Remove dataframe from Schema and update validation checks * Update rest of schema class to stop using dataframe and start moving tests over * Update description and metadata tests * Change over rest of tests from dataframe useage * respond to PR comments * lint fix * Move column creation to it's own file * fix coverage * lint fix * PR comments * Only allow registered LogicalTypes in Schema * More pr comments * Fix release notes after rebase * Add release note * Create WoodworkTableAccessor class init and inspect (#514) * Create Schema class that holds typing info (#499) * Move over methods necessary for init * get basic init working * Add column dictionary to get type inference * cleanup tests * Move more passing tests to schema * fix semantic tags * Fix index and time_index * Allow underlying index to be set * Allow making index column - Koalas broken * Cleanup * Dont allow numpy init * Add repr to schema * add Schema equality check * lint fix * Separate tests into different files * Change dt useage to schema * Fix coverage * Additional column tests * Cleanup datatable usage * Clean up comments * Add release note * Remove dataframe from Schema and update validation checks * Update rest of schema class to stop using dataframe and start moving tests over * Update description and metadata tests * Change over rest of tests from dataframe useage * respond to PR comments * lint fix * Move column creation to it's own file * fix coverage * lint fix * PR comments * Only allow registered LogicalTypes in Schema * More pr comments * Fix release notes after rebase * Add accessor class that creates a schema with params * Add param validation * Add validation tests for accessor * Add getattribute to grab accessor and then schema attrs * Make index in dataframe * Add logical type parsing and inference * Update underlying data dtypes to match ltypes * Add underlying index and sort * Move tests to correct file * add time index and ltype tests * Add type inference tests * Cleanup and catch Attributes that arent present * add api reference and release note * Add init file to accessor test dir * Fix coverage, error for nonexistant attr, and test schema equality * Use getattr instead of getattribute on Accessor * fix coverage * PR comments * Add tests for ordinal and falsy names * check that referencing accessor attrs before schema init is ok * pr comments * More pr comments * Add docstring to init * Change set underlying index docstring * Allow initializing accessor with valid schema (#522) * add _is_valid_schema function * Allow schema passed in on init * Update schema validation to happen with param validation * Fix cverage and add release note * add read_csv_to_accessor that creates a DataFrame with the Schema initialized (#534) * Add read_csv_to_accessor util function * Add release note * Add ability to call DataFrame methods from Accessor (#538) * Add ability to call pandas methods from Accessor * Add more tests for pandas calls * Add erroring checks * Add Release note * Update docstring * Remove indexer test * Warn and set schema to None if inplace operation invalidates schema * Add specific error messages for invalid schemas * Add init info to warning * remove comments * Use warnings for any invalid schema at getattr * Clean up line lengths * Move getattr logic to helpers * PR comments * consolidate warnings * start series accessor implementation * Add column helpers for checking if columns are of a certain type (#553) * Add four is type helpers * cleanup * Add release note * add series name to accessor * multiple updates for series accessor init * update release notes * update function signature * Load demo data with accessor (#556) * load retail data and return dataframe with accessor * Docstring updates * Add release note * lint fix * initial logical type stuff * docstring updates * lint fix * test updates * more test updates * Add `select` to Accessor (#548) * rename to WoodworkColumnAccessor * remove schema property * merge issue fix * update api ref * update release notes * rename test file * update error message * update test comment * remove name from column_dict * remove name property from series accessor Co-authored-by: Tamar Grey <tamar.grey@alteryx.com> Co-authored-by: Tamar Grey <64278226+tamargrey@users.noreply.github.com> * Add mutual information to the Table Accessor (#571) * Add mutual information to Accessor * Dont allow unique mi calculation * cleanup * Change read csv doc * Add release note * PR comments * stop using name in dictionary after rebase * Add describe to the Accessor (#579) * Start implementing describe on accessor * Add describe tests * Test column names in filter schema and handle non string columns * Update documentation * stop passing schema through to describe dict * Fix tests * Add release note * Check all three of col name ltype and tags every time * cleanup filter cols * Refactor filter cols to make more clear (hopefully) * cleanup * Add tag modification methods to series accessor (#573) * add tag update methods to series accessor * update release notes * move tag methods to helper functions * Add util function for initializing series with dtype change (#581) * add series init helper method * update release notes * add new test with all params * update docstring * fix filename * use single update_dtype function for table and column * update error message * update test for new ltype * update error message * add custom TypeConversionError * Remove koalas set option to compute ops on diff frames for now * Move mutual info functions to statistics_utils file (#584) * move over mi helpers * move over get mode * move over mutual info dict function * Cleanup * Add release note * Fix after rebase * use method for mutual information * Allow series calls from the accessor (#589) * add getattr to column accessor * update release notes * deepcopy schema * fix docstring * update warning message * Allow updates to semantic tags on a DataFrame's Schema (#591) * First pass at semantic tag updates * implement set types for tags * Move setting index directly validation to table schema * Handle retaining indices on changing tags * Update tests to check for index tag changes * Fix index tag setting * Fix setting standard tags after removing index tags * Cleanup and account for use_standard_tags when removing * Update documentation * Add release note * pr comments * Add set_logical_type method to series accessor (#590) * add set_logical_type method to series accessor * update release notes * remove tests no longer needed * ltype change warning test * rework tests with new series returned * lint fix * revert test change * add dtype conversion tests * remove duplicate call * copy series inside set_logical_type * Better error when accessing column accessor properties before init (#596) * warn accessing props before init * update release notes * add repr test * update repr * update function name * Create new schema object when going through pandas operations (#595) * Pass new schema object when making pandas operations * Test for deepcopy changes * Add release note * Add to docstring that schema is reused * Return copy of schema in property * pr comments * 523 ignored parameters warning (#593) * warn when parameters are passed with schema * removed comments and debug statements * ready for pr * realease notes updated * fixed release_notes conflict * ignored extra parameters in _validate_accessor_params and other small fixes * i always forget to lint * already_sorted check added * extra line in release_notes again * codecov update * Allow updating index (#603) * Add set index to Schema * Update api ref * Add set index to Accessor * cleanup * use schema index after setting * add release note * PR comments * fix set index twice test * Column accessor update for LatLong columns (#598) * updates for series latlong columns * update release notes * update valid latlong value check * test readability improvement * Implement loc and iloc for Column Accessor (#613) * remove old datacolumn extensionarray test * add column loc and iloc * lint fix * update release notes * update api reference * fix backtick * retain description and metadata * fix docs build * copy tags and metadata * lint fix * fix indexer selection code * update docstring * update docstring * Allow updating time index (#612) * Add set time index to schema and accessor * Add release note * fix pr number * Remove set time index from accessor * PR comments * add api reference * Implements iloc and loc for WoodworkTableAccessor (#618) * initial table loc and iloc work * finish table loc and iloc work * update api-reference * update doctring * update release notes * update selection logic * clean up if condition * error using loc or iloc before init * Update set_types to also set logical types (#619) * Add schema set types * expand combined tests * Improve error message * cleanup * add to api reference * Add set types to accesor * Update schema set types to handle tags better * Update documentation * Add release notes * Cleanup commented out tests * PR comments * Raise error is None semantic tag is supplied for a column * restructure set types * remove comment * Serialize accessor to csv, pickle, and parquet (#624) * Add to_dictionary to Accessor * Allow serialization to csv, pickle, and parquet * Update documentation * dont allow serialization methods to be called if schema not initialized * dont call typing info schema in serialization file * Add release note * copy dataframe and move over typing info * Pr comments * Deserialize accessor from csv, pickle, and parquet to Woodwork table (#626) * get deserialize to csv working * Move over tests * cleanup * Update documentation * add release note * PR comments * fix * fix indentation * Add DaskColumnAccessor (#625) * update init * update datatable utils * update utils * update test accessor utils * update column accessor * more col accessor fixes * update release notes * update indexer * comment change * move helper functions to accessor_utils * lint fix * update test * Add Value counts to table accesor (#632) * Add value counts to table accessor * Add release notes * fix docstring * Add pop to WoodworkTableAccessor (#636) * Add pop method * Add release note * pr comments * Implement KoalasColumnAccessor (#634) * implement KoalasColumnAccessor * update release notes * lint fix * update get_valid_dtype documentation * lint fix again * update get_valid_dtype in tests * pr comments * fix docstring * Bump Koalas min version and fix release notes (#638) * bump koalas min version * update release notes * bump koalas min version * update release notes * add pr number * update contributors * update contributors * Add drop to WoodworkTableAccessor (#640) * Add drop to table accessor * Add release note * PR comments * Remove commented out checks * Add rename to WoodworkTableAccessor (#646) * Add rename to accessor and schema * Add release note * fix pr number * remove datatable usage * Pr comments * Add specific error for not present column * Allow renaming indices * Remove comment * Add Dask support to WoodworkTableAccessor (#648) * initial dask work on table accessor * finish dask support * update release notes * update table docstring * more docstring updates * fix merge issues * Add schema properties to WoodworkTableAccessor (#651) * Add schema properties to table accessor * Add release note * Add KoalasTableAccesor (#652) * remove koalas xfail * fix tests * finish koalas table accessor * update release notes * coverage fixes * update test callable * Adds __getitem__ to table accessor (#633) * Update docstrings and API Reference (#660) * update api ref * docstring updates * implement methods for documentation * update release notes * Preserve pandas underlying index when not creating a Woodwork index (#664) * Set underlying index with woodwork index and don't reset upon removal * Test update methods dont reset index * Add release note * test other params of reset_index * PR comments * fix typo * Fix bug in _reset_semantic_tags causing columns to share the same semantic tags set (#666) * fix reset_semantic_tags bug * update release notes * Make sure column order is maintained when necessary on Woodwork Tables (#677) * Outline tests * Maintain column order on new tables * Maintain column order on type updates * Cleanup * Add release note * Add test where we manually scramble the schema dict * Set Koalas min version to 1.7.0 and update backup dtypes (#678) * updates for Koalas 1.7.0 * update release notes * fix koalas datacolumn tests * lint fix * clean up _update_column_dtype * remove string conversion * Cleanup dtype usage (#682) * change pandas_dtype to primary_dtype * Compare dtype strings instead of objects * Pass type of series to _get_valid_dtype * Add release note * use one entry in release notes * Remove dtype from Schema dictionary (#685) * remove dtype from column * Remove dtype from table schema * remove dtype from table accessor * Update statistics to not use_dtype_in_column * fix getitem and add to_pandas test * Update repr - broken tests * expand repr tests * fix koalas test dtypes * fix docstring * Raise error if no schema inited * look at valid dtype while updating column dtype * add release note * fix valid dtype call * fix coverage * PR comments * Improve error when calling accessor methods or properties before init (#683) * raise better init errors * update release notes * use consistent spacing * be more explicit with error check * automate tests to check all props and methods * update variable names * add getitem init error * more test cases * automate series error tests * create test utils functions * Adds __setitem__ to WoodworkTableAccessor (#669) * Update README and Get Started guide to use accessor (#655) * update readme and get started guide to use accessor * update release notes * pr comments * more readme updates * updates after bug fixes * README improvements * update types in start guide * Update README.md Co-authored-by: Jeff Hernandez <12969559+jeff-hernandez@users.noreply.github.com> * Update docs/source/start.ipynb Co-authored-by: Jeff Hernandez <12969559+jeff-hernandez@users.noreply.github.com> Co-authored-by: Jeff Hernandez <12969559+jeff-hernandez@users.noreply.github.com> * Include index and allow unique columns in Accessor mutual info (#699) * Include unique columns in mutual info calculationms * Add include_index param to mi * add release note * Update types and tags guide to use accessor (#657) * update types and tags guide * update release notes * update after bug fixes * pr feedback * remove table references * pr fix * update wording about index and time_index * Update customizing type inference guide for accessor (#696) * update type inference guide for accessor * update release notes * add link to types and tags * improve natural language explanation * Update statistical insights guide and fix warning (#693) * update statistical insights guide * update release notes * pr feedback * add include_index usage to guide * Include DataFrame in accessor equality check (#700) * Add eq check to accessor looking at dataframe * test use_standard_tags differences * move standard tags test to schema * add release note * compare use_standard_tags when checking equality * Fix serialization * update release note * PR comment * Update Dask and Koalas guide to use accessor (#701) * update dask and koalas guide * update release notes * pr feedback * update index wording * Add missing tests to Schema/Accessor (#712) * Test non string column names * Add tests for instantiated logical types * Add missing describe test * Add duplicate tags test * Add release note * Add accessor type system tests * Add accessor test that uses numeric_time_index_df (#716) * Add test thatuses numeric time index df fixture * Add release note * Update index and install notebooks to use accessor (#715) * Remove datatables usage from index doc * add release note * update install notebook * update release notes * Remove DataTable and DataColumn classes (#713) * Add Column Accessor Examples to Start Documentation (#717) * add series accessor usage to guide * update release notes * pr feedback improvements * clear notebook output * Change dtype of sample_series and remove convert_series util (#720) * use correct dtypes with sample_series * Remove convert_series from column accessor tests * remove convert_series from indexer tests * remove convert_series completly * Add release note * use object dtype for init_series tests * Rename Accessor methods (#723) * Add section to types and tags guide about schema validity (#729) * Add section to types and tags for valid schema * Add note to start about validity * fix level of header * fix note formatting * Add release note * PR comments * Use pd.read_csv for readme and get started (#730) * use pd.read_csv * update release notes * Small fixes to documentation (#731) * Fix tags and index doc * add release note * remove extra characters Co-authored-by: Nate Parsons <4307001+thehomebrewnerd@users.noreply.github.com> Co-authored-by: John Bridstrup <john.bridstrup@gmail.com> Co-authored-by: Jeff Hernandez <12969559+jeff-hernandez@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #709 by renaming accessor methods since DataTable has already been removed.