Fix handling of where clauses #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1 +/- ##
==========================================
+ Coverage 70.79% 71.50% +0.70%
==========================================
Files 8 8
Lines 363 365 +2
==========================================
+ Hits 257 261 +4
+ Misses 106 104 -2
Continue to review full report at Codecov.
|
|
Good catch, thanks! The CI error is indeed unrelated, so I'll merge as-is. |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that where clauses from the original trait were missing in the derived impls. This can lead to compile errors if default impls within the trait rely on those constraints. I added the required code to the derive macros as well as test cases for it.
The error in the CI seems to be a result of a chanced rustc error message on the nightly toolchain.