Prevent skip change event in AltStore #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…componentDidMount
|
Hi @goatslacker , i'm having this same issue, basically changes made to the store during the initialization of the container's child component won't propagate :S |
|
This PR has some problems. When using Server Side Rendering like Iso, Memory Leak issue can occur because only componentWillMount is called in the rendering. so you have to avoid this problem yourself. |
# Conflicts: # package.json
This reverts commit 32bc0e3.
prcolaco
pushed a commit
to decentrawise/alt-container
that referenced
this pull request
Mar 7, 2024
…parser-js-0.7.33 Bump ua-parser-js from 0.7.31 to 0.7.33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent render -> Child render -> Child did mount -> Parent did mountAs you see, Child Component will mounted first. If It does trigger action related the Store that parent component has, Parent can't listen it. because Parent doesn't mounted yet. so I moved listening stores to
componentWillMount.