Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement password recovery #37

Merged
merged 2 commits into from
Sep 28, 2021
Merged

Implement password recovery #37

merged 2 commits into from
Sep 28, 2021
+670 −105

Conversation

hugopeixoto
Copy link
Member

@hugopeixoto hugopeixoto commented Sep 12, 2021 •
edited
Loading

Implements password recovery, plus a few random fixes:

  • Add footer with links
  • Fix cookie policy filenames
  • Add CSP headers
  • Add Referrer-Policy header
  • Set session cookie to Same-Site Strict
  • Add security considerations to CONTRIBUTING.md
  • Add writing style to CONTRIBUTING.md
  • Set password minimum length to 10 (frontend only, still lacks server side validation)
  • Add missing translations (header messages, form buttons, page headers)
  • Add missing schema.rb changes from latest rails upgrade

@hugopeixoto hugopeixoto mentioned this pull request Sep 14, 2021
Closed
@hugopeixoto hugopeixoto marked this pull request as ready for review September 21, 2021 01:30
@hugopeixoto hugopeixoto changed the title wip Implement password recovery Sep 21, 2021
@hugopeixoto hugopeixoto mentioned this pull request Sep 21, 2021
Closed
@ZeCarlosCoutinho
Copy link
Collaborator

Thanks for all the updates with the text changes. However, try to keep it in a separate commit next time (and in a separate PR).

@ZeCarlosCoutinho
Copy link
Collaborator

Isn't the server-side password-length verification easy to implement? It would be good if you could already include it here, since you changed it.

@ZeCarlosCoutinho
Copy link
Collaborator

Besides this, looks good to me

@hugopeixoto
Copy link
Member Author

Isn't the server-side password-length verification easy to implement? It would be good if you could already include it here, since you changed it.

it should be. I'll take a look at it in a bit

@hugopeixoto
Copy link
Member Author

Review issues addressed, merging

@hugopeixoto hugopeixoto merged commit 08714a0 into main Sep 28, 2021
@hugopeixoto hugopeixoto deleted the feature/password-recovery branch September 28, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeCarlosCoutinho ZeCarlosCoutinho ZeCarlosCoutinho left review comments

@josealeixopc josealeixopc Awaiting requested review from josealeixopc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugopeixoto @ZeCarlosCoutinho