Use with ARC

[mikezang]

How can I use your source with ARC?

[markrickert]

Easy: http://stackoverflow.com/questions/6646052/how-can-i-disable-arc-for-a-single-file-in-a-project

[mikezang]

I found the compile warning is not for ARC, they are from static analyzer, can you check this thread?
http://forums.macrumors.com/showthread.php?t=1379825&goto=newpost

Sent from my iPhone4S

On 2012/06/04, at 23:24, Mark Rickertreply@reply.github.com wrote:

Easy: http://stackoverflow.com/questions/6646052/how-can-i-disable-arc-for-a-single-file-in-a-project

---

Reply to this email directly or view it on GitHub:
#2 (comment)

[markrickert]

I've submitted a pull request. #3

There's not a huge issue here, it was just the static analyzer complaining about the function names that returned retained objects.

For now, you can use my branch that fixes this if you'd like: markrickert/FPPopover@12a097aee05dd1980d900b345b63db3ce187d95b

[mikezang]

I found that you used a lot of IVAR directly, why don't you use property?
for example,
[_window release];
[_parentView release];
_parentView=nil;

[markrickert]

@mikezang,

You'd need to ask the library creator (not me). I'm guessing it's just personal coding style/preferences.

[alvises]

hi @mikezang,

I have used iVar directly because this is what it has to do when we don't want to expose the iVars like _window. If you use properties you will expose the ivars outside the instance.

Thanks

[alvises]

@mikezang : thanks to @markrickert now static analyzer giving warnings

[mikezang]

Thanks for your reply, Alvise.

I think you can put property in implement file so that you don't need worry about expose to outside.

Sent from my iPhone4S

On 2012/06/08, at 0:13, Alvise Susmelreply@reply.github.com wrote:

hi @mikezang,

I have used iVar directly because this is what it has to do when we don't want to expose the iVars like _window. If you use properties you will expose the ivars outside the instance.

Thanks

---

Reply to this email directly or view it on GitHub:
#2 (comment)