Fix Linux SW encoder for h264 #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nowrep
force-pushed
the
linux-swencode
branch
2 times, most recently
from
ba644ca
to
d035e3e
Compare
deiteris
reviewed
Dec 28, 2022
| encoder_ctx->max_b_frames = 0; | ||
| encoder_ctx->gop_size = 0; |
There was a problem hiding this comment.
Just in case, while it's fixing the issue, it's producing only IDR frames when set to 0.
nowrep
force-pushed
the
linux-swencode
branch
3 times, most recently
from
d442ac0
to
fdd0349
Compare
nowrep
force-pushed
the
linux-swencode
branch
from
fdd0349
to
8e9bbce
Compare
h265 is still broken and it now fails to create.
nowrep
force-pushed
the
linux-swencode
branch
from
8e9bbce
to
040c275
Compare
zarik5
pushed a commit
that referenced
this pull request
Feb 9, 2023
h265 is still broken and it now fails to create.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latency is actually pretty decent and it could be further reduced by doing the rgb -> yuv conversion on GPU.