Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR2777] Remove warnings (gcc/clang) #5

Merged
merged 3 commits into from
Mar 28, 2023
Merged

[PR2777] Remove warnings (gcc/clang) #5

merged 3 commits into from
Mar 28, 2023

Conversation

fredroy
Copy link

@fredroy fredroy commented Mar 28, 2023

Just a quick pass on gcc/clang.
remove warnings about : override, not used warnings and hidden overloads

removing repetitive getValues() in MatrixLinearSolver (because I just happen to see it...)

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy mentioned this pull request Mar 28, 2023
Merged
alxbilger
alxbilger approved these changes Mar 28, 2023
View reviewed changes
Copy link
Owner

@alxbilger alxbilger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks a lot

@alxbilger alxbilger merged commit 48354bd into alxbilger:local_forcefield_matrix Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxbilger alxbilger alxbilger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@fredroy @alxbilger