Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error on removeSelection when no blocks exist #118

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Error on removeSelection when no blocks exist #118

wants to merge 2 commits into from

Commits on Mar 22, 2021

  1. Error on removeSelection when no blocks exist 

    Add a null check in removeSelection when parentNode evaluates to null
    @jackbanditdude
    jackbanditdude committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    49d6556 View commit details
    Browse the repository at this point in the history

  2. blockSnap ignores return type 

    In firstBlock(), the blockSnap() function call ignores the return type, unlike other places we use blockSnap(). Adding in false check and removeSelection() call.
    @jackbanditdude
    jackbanditdude committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    2128398 View commit details
    Browse the repository at this point in the history