Merge pull request #9 from am-kantox/feature/#7-multicall

`multi_call/3` → closes #7

lib/siblings.ex

@@ -101,6 +101,18 @@ defmodule Siblings do
     |> InternalWorker.call(message)
   end
 
+  @doc """
+  Performs a `GenServer.call/3` on all the workers.
+  """
+  @spec multi_call(module(), Worker.message()) ::
+          [Worker.call_result() | {:error, :callback_not_implemented}]
+  def multi_call(name \\ default_fqn(), message) do
+    :pids
+    |> children(name)
+    |> Task.async_stream(&InternalWorker.call(&1, message))
+    |> Enum.map(&elem(&1, 1))
+  end
+
   @doc """
   Resets the the named worker’s interval.
   """

test/siblings_test.exs

@@ -6,6 +6,7 @@ defmodule SiblingsTest do
 
   setup do
     %{siblings: start_supervised!(Siblings)}
+    # on_exit(fn -> Process.sleep(100) end)
   end
 
   test "Worker with FSM" do
@@ -54,7 +55,7 @@ defmodule SiblingsTest do
     assert [] == Siblings.children()
   end
 
-  test "Multi" do
+  test "#multi_transition/3" do
     {:ok, _pid1} =
       Siblings.start_child(Siblings.Test.NoPerform, "NoPerform1", %{pid: self()}, interval: 60_000)
 
@@ -76,4 +77,41 @@ defmodule SiblingsTest do
 
     assert [] == Siblings.children()
   end
+
+  test "#call/3" do
+    {:ok, _pid1} =
+      Siblings.start_child(Siblings.Test.NoPerform, "Callable1", %{pid: self()}, interval: 60_000)
+
+    {:ok, _pid2} =
+      Siblings.start_child(Siblings.Test.Callable, "Callable2", %{pid: self()}, interval: 60_000)
+
+    assert {:error, :callback_not_implemented} == Siblings.call("Callable1", 42)
+    assert 84 == Siblings.call("Callable2", 42)
+
+    Siblings.multi_transition(:to_s2, nil)
+    Siblings.multi_transition(:to_s3, nil)
+    Siblings.multi_transition(:__end__, nil)
+
+    Process.sleep(100)
+
+    assert [] == Siblings.children()
+  end
+
+  test "#multi_call/2" do
+    {:ok, _pid1} =
+      Siblings.start_child(Siblings.Test.NoPerform, "Callable1", %{pid: self()}, interval: 60_000)
+
+    {:ok, _pid2} =
+      Siblings.start_child(Siblings.Test.Callable, "Callable2", %{pid: self()}, interval: 60_000)
+
+    assert [84, {:error, :callback_not_implemented}] == Enum.sort(Siblings.multi_call(42))
+
+    Siblings.multi_transition(:to_s2, nil)
+    Siblings.multi_transition(:to_s3, nil)
+    Siblings.multi_transition(:__end__, nil)
+
+    Process.sleep(100)
+
+    assert [] == Siblings.children()
+  end
 end

test/support/callable.ex

@@ -0,0 +1,21 @@
+defmodule Siblings.Test.Callable do
+  @moduledoc false
+
+  require Logger
+
+  @behaviour Siblings.Worker
+
+  @impl Siblings.Worker
+  def perform(_, _, _), do: :noop
+
+  @impl Siblings.Worker
+  def on_call(message, state) when is_integer(message),
+    do: {message * 2, state}
+
+  @fsm """
+  s1 --> |to_s2| s2
+  s2 --> |to_s3| s3
+  """
+
+  use Finitomata, @fsm
+end