Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADO-25882 - Lex V2 Provisioning Tooling #14

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

zoiec
Copy link
Contributor

@zoiec zoiec commented Jul 7, 2021

🐘
This PR adds a unit tests ci for gh actions to lint then run tests

  • Added eslint config
  • Added ci file
  • Fixed simple linting errors, quotes, trailing commas etc
  • Added eslint disable rules in files where needed

ADO LINK: https://dev.azure.com/AMA-Ent/AMA-Ent/_boards/board/t/Red%20Team/Stories/?workitem=25882

@zoiec zoiec changed the base branch from lex-v2-integration to master July 7, 2021 17:52
@zoiec zoiec changed the base branch from master to lex-v2-integration July 7, 2021 17:52
@zoiec zoiec force-pushed the lex-v2-integration-eslint branch 5 times, most recently from 047d617 to 9965314 Compare July 7, 2021 19:23
🐘
This PR adds a unit tests ci for gh actions to lint then run tests

- Added eslint config
- Added ci file
- Fixed simple linting errors, quotes, trailing commas etc
- Added eslint disable rules in files where needed

ADO LINK: https://dev.azure.com/AMA-Ent/AMA-Ent/_boards/board/t/Red%20Team/Stories/?workitem=25882
@zoiec zoiec force-pushed the lex-v2-integration-eslint branch from 9965314 to 559966a Compare July 7, 2021 19:41
@zoiec zoiec marked this pull request as ready for review July 7, 2021 19:44
@zoiec zoiec requested a review from a team as a code owner July 7, 2021 19:44
Copy link
Contributor

@tehzwen tehzwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Zoie!

@zoiec zoiec merged commit b46453d into lex-v2-integration Jul 7, 2021
@zoiec zoiec deleted the lex-v2-integration-eslint branch July 7, 2021 20:13
jessedoyle pushed a commit that referenced this pull request Jul 8, 2021
ADO-25882 - Lex V2 Provisioning Tooling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants