Rename field to match xml field name;

amabnl · Sep 24, 2020 · ad8eb04 · ad8eb04
1 parent 0a52791
commit ad8eb04
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 22 deletions.
diff --git a/src/Amadeus/Client/Struct/MiniRule/GetFromRec.php b/src/Amadeus/Client/Struct/MiniRule/GetFromRec.php
@@ -52,7 +52,7 @@ public function __construct(MiniRuleGetFromRecOptions $options)
         }
 
         $obj = new GroupRecords();
-        $obj->recordId = new RecordId($options->pricing->id, $options->pricing->type);
+        $obj->recordID = new RecordId($options->pricing->id, $options->pricing->type);
 
         if (isset($options->filteringOptions)) {
             $obj->filteringSelection = new FilteringSelection();

diff --git a/src/Amadeus/Client/Struct/MiniRule/GroupRecords.php b/src/Amadeus/Client/Struct/MiniRule/GroupRecords.php
@@ -34,7 +34,7 @@ class GroupRecords
     /**
      * @var RecordId
      */
-    public $recordId;
+    public $recordID;
     /**
      * @var FilteringSelection
      */

diff --git a/tests/Amadeus/Client/Struct/MiniRule/GetFromRecTest.php b/tests/Amadeus/Client/Struct/MiniRule/GetFromRecTest.php
@@ -51,8 +51,8 @@ public function testCanMakeMiniRulesRequestForAllOffers()
         $message = new GetFromRec($opt);
 
         $this->assertCount(1, $message->groupRecords);
-        $this->assertEquals(RecordId::REFERENCE_TYPE_OFFER, $message->groupRecords[0]->recordId->referenceType);
-        $this->assertEquals(RecordId::PRICING_ID_ALL, $message->groupRecords[0]->recordId->uniqueReference);
+        $this->assertEquals(RecordId::REFERENCE_TYPE_OFFER, $message->groupRecords[0]->recordID->referenceType);
+        $this->assertEquals(RecordId::PRICING_ID_ALL, $message->groupRecords[0]->recordID->uniqueReference);
     }
 
     public function testCanMakeMiniRulesRequestForSpecificOffer()
@@ -67,8 +67,8 @@ public function testCanMakeMiniRulesRequestForSpecificOffer()
         $message = new GetFromRec($opt);
 
         $this->assertCount(1, $message->groupRecords);
-        $this->assertEquals(RecordId::REFERENCE_TYPE_OFFER, $message->groupRecords[0]->recordId->referenceType);
-        $this->assertEquals(2, $message->groupRecords[0]->recordId->uniqueReference);
+        $this->assertEquals(RecordId::REFERENCE_TYPE_OFFER, $message->groupRecords[0]->recordID->referenceType);
+        $this->assertEquals(2, $message->groupRecords[0]->recordID->uniqueReference);
     }
 
     public function testCanMakeMiniRulesRequestForAllPqrs()
@@ -83,8 +83,8 @@ public function testCanMakeMiniRulesRequestForAllPqrs()
         $message = new GetFromRec($opt);
 
         $this->assertCount(1, $message->groupRecords);
-        $this->assertEquals(RecordId::REFERENCE_TYPE_PROD_QUOTATION, $message->groupRecords[0]->recordId->referenceType);
-        $this->assertEquals(RecordId::PRICING_ID_ALL, $message->groupRecords[0]->recordId->uniqueReference);
+        $this->assertEquals(RecordId::REFERENCE_TYPE_PROD_QUOTATION, $message->groupRecords[0]->recordID->referenceType);
+        $this->assertEquals(RecordId::PRICING_ID_ALL, $message->groupRecords[0]->recordID->uniqueReference);
     }
 
     public function testCanMakeMiniRulesRequestForSpecificTst()
@@ -99,8 +99,8 @@ public function testCanMakeMiniRulesRequestForSpecificTst()
         $message = new GetFromRec($opt);
 
         $this->assertCount(1, $message->groupRecords);
-        $this->assertEquals(RecordId::REFERENCE_TYPE_TST, $message->groupRecords[0]->recordId->referenceType);
-        $this->assertEquals(1, $message->groupRecords[0]->recordId->uniqueReference);
+        $this->assertEquals(RecordId::REFERENCE_TYPE_TST, $message->groupRecords[0]->recordID->referenceType);
+        $this->assertEquals(1, $message->groupRecords[0]->recordID->uniqueReference);
     }
 
     public function testCanMakeMiniRulesRequestForAllFRN()
@@ -115,8 +115,8 @@ public function testCanMakeMiniRulesRequestForAllFRN()
         $message = new GetFromRec($opt);
 
         $this->assertCount(1, $message->groupRecords);
-        $this->assertEquals(RecordId::REFERENCE_TYPE_FARE_RECOMMENDATION_NUMBER, $message->groupRecords[0]->recordId->referenceType);
-        $this->assertEquals(RecordId::PRICING_ID_ALL, $message->groupRecords[0]->recordId->uniqueReference);
+        $this->assertEquals(RecordId::REFERENCE_TYPE_FARE_RECOMMENDATION_NUMBER, $message->groupRecords[0]->recordID->referenceType);
+        $this->assertEquals(RecordId::PRICING_ID_ALL, $message->groupRecords[0]->recordID->uniqueReference);
     }
 
     public function testCanMakeMiniRulesRequestForAllFUN()
@@ -131,8 +131,8 @@ public function testCanMakeMiniRulesRequestForAllFUN()
         $message = new GetFromRec($opt);
 
         $this->assertCount(1, $message->groupRecords);
-        $this->assertEquals(RecordId::REFERENCE_TYPE_FARE_UPSELL_RECOMMENDATION_NUMBER, $message->groupRecords[0]->recordId->referenceType);
-        $this->assertEquals(RecordId::PRICING_ID_ALL, $message->groupRecords[0]->recordId->uniqueReference);
+        $this->assertEquals(RecordId::REFERENCE_TYPE_FARE_UPSELL_RECOMMENDATION_NUMBER, $message->groupRecords[0]->recordID->referenceType);
+        $this->assertEquals(RecordId::PRICING_ID_ALL, $message->groupRecords[0]->recordID->uniqueReference);
     }
 
     public function testCanMakeMiniRulesRequestForPNR()
@@ -147,8 +147,8 @@ public function testCanMakeMiniRulesRequestForPNR()
         $message = new GetFromRec($opt);
 
         $this->assertCount(1, $message->groupRecords);
-        $this->assertEquals(RecordId::REFERENCE_TYPE_RECORD_LOCATOR, $message->groupRecords[0]->recordId->referenceType);
-        $this->assertEquals("RECLOCNUM123", $message->groupRecords[0]->recordId->uniqueReference);
+        $this->assertEquals(RecordId::REFERENCE_TYPE_RECORD_LOCATOR, $message->groupRecords[0]->recordID->referenceType);
+        $this->assertEquals("RECLOCNUM123", $message->groupRecords[0]->recordID->uniqueReference);
     }
 
     public function testCanMakeMiniRulesRequestForPNRWithSpecificPassenger()
@@ -169,8 +169,8 @@ public function testCanMakeMiniRulesRequestForPNRWithSpecificPassenger()
         $message = new GetFromRec($opt);
 
         $this->assertCount(1, $message->groupRecords);
-        $this->assertEquals(RecordId::REFERENCE_TYPE_RECORD_LOCATOR, $message->groupRecords[0]->recordId->referenceType);
-        $this->assertEquals("RECLOCNUM123", $message->groupRecords[0]->recordId->uniqueReference);
+        $this->assertEquals(RecordId::REFERENCE_TYPE_RECORD_LOCATOR, $message->groupRecords[0]->recordID->referenceType);
+        $this->assertEquals("RECLOCNUM123", $message->groupRecords[0]->recordID->uniqueReference);
         $this->assertCount(1, $message->groupRecords[0]->filteringSelection->referenceDetails);
         $this->assertEquals(ReferenceDetails::REFERENCE_TYPE_PAX, $message->groupRecords[0]->filteringSelection->referenceDetails[0]->type);
         $this->assertEquals(1, $message->groupRecords[0]->filteringSelection->referenceDetails[0]->value);
@@ -194,8 +194,8 @@ public function testCanMakeMiniRulesRequestForPNRWithSpecificSegment()
         $message = new GetFromRec($opt);
 
         $this->assertCount(1, $message->groupRecords);
-        $this->assertEquals(RecordId::REFERENCE_TYPE_RECORD_LOCATOR, $message->groupRecords[0]->recordId->referenceType);
-        $this->assertEquals("RECLOCNUM123", $message->groupRecords[0]->recordId->uniqueReference);
+        $this->assertEquals(RecordId::REFERENCE_TYPE_RECORD_LOCATOR, $message->groupRecords[0]->recordID->referenceType);
+        $this->assertEquals("RECLOCNUM123", $message->groupRecords[0]->recordID->uniqueReference);
         $this->assertCount(1, $message->groupRecords[0]->filteringSelection->referenceDetails);
         $this->assertEquals(ReferenceDetails::REFERENCE_TYPE_SEGMENT, $message->groupRecords[0]->filteringSelection->referenceDetails[0]->type);
         $this->assertEquals(2, $message->groupRecords[0]->filteringSelection->referenceDetails[0]->value);
@@ -220,8 +220,8 @@ public function testCanMakeMiniRulesRequestForPNRWithSpecificLanguage()
         $this->assertEquals(\Amadeus\Client\Struct\MiniRule\Language::LQ_LANGUAGE_NORMALLY_USED, $message->language->languageQualifier);
         $this->assertEquals("UA", $message->language->languageDetails->languageCode);
         $this->assertCount(1, $message->groupRecords);
-        $this->assertEquals(RecordId::REFERENCE_TYPE_RECORD_LOCATOR, $message->groupRecords[0]->recordId->referenceType);
-        $this->assertEquals("RECLOCNUM123", $message->groupRecords[0]->recordId->uniqueReference);
+        $this->assertEquals(RecordId::REFERENCE_TYPE_RECORD_LOCATOR, $message->groupRecords[0]->recordID->referenceType);
+        $this->assertEquals("RECLOCNUM123", $message->groupRecords[0]->recordID->uniqueReference);
     }
 
 }