-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
$client->SecuritySignOut() is creating a new session instead of closing existing one. #428
Comments
I can only imagine that at the moment you do your signout call, you no longer have the session in context. You should review when the client gets initialized in your code, and what its lifespan is. I can assure you this is working just fine - this library has been around 5 years now. |
Hi, I have edited my questiong by adding a log file. I have a trait class with this: `
|
Yes, I checked this too. |
Hi @DerMika Please have a look at the below comments. Thank you for your help. |
Make sure you validate that your initial call actually succeeds in signing in. If your initial call fails to sign in, i'm not sure what the result will be. |
Thank you for your reply @DerMika . I just tested when pnr_retrieve call succeed and SecuritySignOut call work perfectly by closing the session. So my problem is when the previous call failed. I still have session ID and I want to close that session by sending a SecuritySignOut call. |
Since it's been years i've worked with PHP and no longer have access to Amadeus, I suggest the best course of action is for you to either avoid this problem by checking if you have an active session before sending a signout (check |
I checked that but it still sending a TransactionStatusCode="start". I will try to investigate the library. Thank you @DerMika for your time. |
Closing this as you've created a new issue for the same problem |
No, a Signout has to be implemented by you yourself. Otherwise you will have problems when trying to get the application certified by Amadeus (which is needed for production access). That is because an active session uses server resources on Amadeus' infrastructure.
Session signout is explained here
Originally posted by @DerMika in #151 (comment)
Hi @DerMika
Following your thought above, I was trying to implement the SecuritySignOut message to release the current session but instead of that it is creating a new session and ending this one only. So then I had always a session unclosed.
Please help me, I need it for UAT.
log.txt
The text was updated successfully, but these errors were encountered: