GETTING EMPTY SESSION ARRAY WHEN PNR_RETRIEVE CALL FAILED

[dil-hf]

Hi,

Is it normal to have an empty array session when PNR-Retrieve fails?
Whenever it failed, getSessionData() is empty.

@bimusiek @DerMika

[DerMika]

You should configure the Request & Response logging https://github.com/amabnl/amadeus-ws-client/blob/master/docs/how-to.rst#logging-request-and-response to find out in detail what goes wrong.

Also, is this a duplicate of #428 ?

[dil-hf]

@DerMika I have logging configured, I can't get the wrong event since one week now.
Please help me figure it out. Below is my log file:

laravel-2021-02-16.log

[DerMika]

The response to your PNR_Retrieve on line 61 of your logfile contains session data and has TransactionStatusCode="InSeries". If you check your $client->getSessionData(); after receiving this response, you should get session info.

Something must be happening to the state of $client in the second between line 61 and 62 of your client...

Also, lines 65-67 contain sensitive info, you may want to strip that.

[DerMika]

Can you try running the client code with a debugger enabled?

Set a breakpoint at https://github.com/amabnl/amadeus-ws-client/blob/master/src/Amadeus/Client/Session/Handler/SoapHeader4.php#L209 and step through this function and see if it picks up the session info when handling the response of the PNR_Retrieve.

If it picks that up, the problem is the state of $client in your code. If it doesn't, it may be a bug or an incompatibility with your WSAP.

[dil-hf]

Thank you @DerMika for your time.

I debug and find out that when PNR_retrieve failed (I mean with wrong PNR), the function getSessionDataFromHeader() is never called but it's being called when PNR_retrieve succeed.
is it normal?

[dil-hf]

Hi @DerMika

Can you guide me on how to get session info so that I can make a raw request as a workaround for avoiding losing the Amadeus slot?
Actually, $client->getSessionData(); is empty when pnr_retrieve failed but it getting logged.
Security_SignOut() works great when pnr_retrieve succeed.

Did anyone encounter the same issue as I do?
Exist any other workaround to close an active session after a failed call?

Thank you for your time.

[DerMika]

I found the problem. A PR is on the way...

[dil-hf]

Hi ,

I got it also. I made the modification locally.
I was preparing the PR.

[dil-hf]

Only one line added, so can I send it?

[DerMika]

Well, i already made it. But since you have it running locally, can you verify that the fix (#430) actually solves your problem? If so I can merge it to master

[dil-hf]

You can merge it, it's the same one I made locally.

[DerMika]

released v1.12.0 which includes this fix.

[dil-hf]

Great, thank you