Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorter version column, use default charset for mysql #391

Merged
merged 1 commit into from Feb 26, 2023

Conversation

amacneil
Copy link
Owner

  • Use default charset for mysql
  • Change version column from varchar(256) to varchar(128) to avoid issues with utf8mb4 on mysql. Made this change on all drivers for consistency.

Refs:

@amacneil
Copy link
Owner Author

@mheffner can you test

@mheffner
Copy link

Looks good!

> show create table schema_migrations;
+-------------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Table             | Create Table                                                                                                                                                       |
+-------------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| schema_migrations | CREATE TABLE `schema_migrations` (
  `version` varchar(128) NOT NULL,
  PRIMARY KEY (`version`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_general_ci |
+-------------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------------+

Copy link

@mheffner mheffner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@amacneil amacneil merged commit 3fe17e0 into main Feb 26, 2023
@amacneil amacneil deleted the adrian/shorterversion branch February 26, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants