Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shorter version column, use default charset for mysql #391

Merged
merged 1 commit into from Feb 26, 2023
Merged

Shorter version column, use default charset for mysql #391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/driver/mysql/mysql.go
View file
Open in desktop
Expand Up @@ -245,8 +245,8 @@ func (drv *Driver) MigrationsTableExists(db *sql.DB) (bool, error) {

// CreateMigrationsTable creates the schema_migrations table
func (drv *Driver) CreateMigrationsTable(db *sql.DB) error {
_, err := db.Exec(fmt.Sprintf("create table if not exists %s "+
"(version varchar(255) primary key) character set latin1 collate latin1_bin",
_, err := db.Exec(fmt.Sprintf(
"create table if not exists %s (version varchar(128) primary key)",
drv.quotedMigrationsTableName()))

return err
Expand Down
5 changes: 3 additions & 2 deletions pkg/driver/postgres/postgres.go
View file
Open in desktop
Expand Up @@ -247,8 +247,9 @@ func (drv *Driver) CreateMigrationsTable(db *sql.DB) error {
}

// first attempt at creating migrations table
createTableStmt := fmt.Sprintf("create table if not exists %s.%s", schema, migrationsTable) +
" (version varchar(255) primary key)"
createTableStmt := fmt.Sprintf(
"create table if not exists %s.%s (version varchar(128) primary key)",
schema, migrationsTable)
_, err = db.Exec(createTableStmt)
if err == nil {
// table exists or created successfully
Expand Down
6 changes: 3 additions & 3 deletions pkg/driver/sqlite/sqlite.go
View file
Open in desktop
Expand Up @@ -174,9 +174,9 @@ func (drv *Driver) MigrationsTableExists(db *sql.DB) (bool, error) {

// CreateMigrationsTable creates the schema migrations table
func (drv *Driver) CreateMigrationsTable(db *sql.DB) error {
_, err := db.Exec(
fmt.Sprintf("create table if not exists %s ", drv.quotedMigrationsTableName()) +
"(version varchar(255) primary key)")
_, err := db.Exec(fmt.Sprintf(
"create table if not exists %s (version varchar(128) primary key)",
drv.quotedMigrationsTableName()))

return err
}
Expand Down