Disable auth check to support older clients #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To re enable auth check for everyone sometime in future, we only need to remove the |
cpg
reviewed
Jul 3, 2018
src/fs/auth.go
Outdated
| func (service *MercuryFsService) authenticate(writer http.ResponseWriter, request *http.Request) { | ||
| // decode and parse json request body | ||
| decoder := json.NewDecoder(request.Body) | ||
| data := make(map[string]interface{}) | ||
| err := decoder.Decode(&data) | ||
| if err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
does this mean that client data in json (malformed) may crash our service?
There was a problem hiding this comment.
Thanks for pointing it out. I have corrected it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It disables auth check (so no 401 or 403 status codes are sent) so that older clients do not start throwing errors but if an
Authorizationheader is supplied (by newer clients), then sends appropriate response (ex limiting shares to what that user can see).