configurable rule ids

controller/rules/memorymanager.go

@@ -197,7 +197,9 @@ func (m *memory) deleteRulesByFilter(namespace string, filter api.RuleFilter) er
 
 func (m *memory) generateRuleIDs(rules []api.Rule) {
 	for i := range rules {
-		rules[i].ID = uuid.New() // Generate an ID for each rule
+		if rules[i].ID == "" {
+			rules[i].ID = uuid.New() // Generate an ID for each rule
+		}
 	}
 }
 

controller/rules/redismanager.go

@@ -51,14 +51,15 @@ func (r *redisManager) AddRules(namespace string, rules []api.Rule) (NewRules, e
 
 	entries := make(map[string]string)
 	for i := range rules {
-		id := uuid.New() // Generate an ID for each rule
-		rules[i].ID = id
+		if rules[i].ID == "" {
+			rules[i].ID = uuid.New() // Generate an ID for each rule
+		}
 		data, err := json.Marshal(&rules[i])
 		if err != nil {
 			return NewRules{}, &JSONMarshalError{Message: err.Error()}
 		}
 
-		entries[id] = string(data)
+		entries[rules[i].ID] = string(data)
 	}
 
 	if err := r.db.InsertEntries(namespace, entries); err != nil {

testing/test-scripts/bookinfo-default-route-details.yaml

@@ -1,5 +1,6 @@
 rules:
-- priority: 1
+- id: bookinfo-default-route-details
+  priority: 1
   destination: details
   route:
     backends:

testing/test-scripts/bookinfo-default-route-productpage.yaml

@@ -1,5 +1,6 @@
 rules:
-- priority: 1
+- id: bookinfo-default-route-productpage
+  priority: 1
   destination: productpage
   route:
     backends:

testing/test-scripts/bookinfo-default-route-ratings.yaml

@@ -1,5 +1,6 @@
 rules:
-- priority: 1
+- id: bookinfo-default-route-ratings
+  priority: 1
   destination: ratings
   route:
     backends:

testing/test-scripts/bookinfo-default-route-reviews.yaml

@@ -1,5 +1,6 @@
 rules:
-- priority: 1
+- id: bookinfo-default-route-reviews
+  priority: 1
   destination: reviews
   route:
     backends:

testing/test-scripts/bookinfo-jason-7s-delay.yaml

@@ -1,5 +1,6 @@
 rules:
-- priority: 10
+- id: bookinfo-jason-7s-delay
+  priority: 10
   destination: ratings
   match:
     source:

testing/test-scripts/bookinfo-jason-reviews-v2-route-rules.yaml

@@ -1,5 +1,6 @@
 rules:
-- priority: 2
+- id: bookinfo-jason-reviews-v2-route-rules
+  priority: 2
   destination: reviews
   match:
     headers:

testing/test-scripts/bookinfo-reviews-routing.yaml

@@ -1,5 +1,6 @@
 rules:
-- priority: 1
+- id: bookinfo-reviews-routing
+  priority: 1
   destination: reviews
   route:
     backends:

testing/test-scripts/helloworld-default-route-rules.json

@@ -1,2 +1,2 @@
-{"rules": [{"priority": 1, "route": {"backends": [{"tags": ["version=v1"]}]}, "destination": "helloworld"}]}
+{"rules": [{"id": "helloworld-default-route-rules", "priority": 1, "route": {"backends": [{"tags": ["version=v1"]}]}, "destination": "helloworld"}]}
 

testing/test-scripts/helloworld-v1-v2-route-rules.json

@@ -1,2 +1,2 @@
-{"rules": [{"priority": 1, "route": {"backends": [{"weight": 0.25, "tags": ["version=v2"]},{"tags":["version=v1"]}]}, "destination": "helloworld"}]}
+{"rules": [{"id": "helloworld-v1-v2-route-rules", "priority": 1, "route": {"backends": [{"weight": 0.25, "tags": ["version=v2"]},{"tags":["version=v1"]}]}, "destination": "helloworld"}]}