Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Apply useMemo for useRouter returned from createLocalizedPathnamesNavigation to keep a stable reference when possible #1201

Merged
merged 1 commit into from
Jul 15, 2024
Merged

fix: Apply useMemo for useRouter returned from createLocalizedPathnamesNavigation to keep a stable reference when possible #1201

merged 1 commit into from
Jul 15, 2024

Conversation

amannn
Copy link
Owner

@amannn amannn commented Jul 15, 2024 •
edited
Loading

Fix #1198

@amannn
fix: Use useMemo for useRouter returned from `createLocalizedPath…
5368834 
…namesNavigation` to keep a stable reference when possible
@vercel Vercel
Copy link

vercel bot commented Jul 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-intl-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 11:45am
next-intl-example-app-router ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 11:45am
next-intl-example-app-router-without-i18n-routing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 11:45am

@amannn amannn mentioned this pull request Jul 15, 2024
Closed
3 tasks
@amannn amannn marked this pull request as ready for review July 15, 2024 11:44
@amannn amannn changed the title fix: Use useMemo for useRouter returned from createLocalizedPathnamesNavigation to keep a stable reference when possible fix: Apply useMemo for useRouter returned from createLocalizedPathnamesNavigation to keep a stable reference when possible Jul 15, 2024
@amannn amannn merged commit a1b9a36 into main Jul 15, 2024
8 checks passed
@amannn amannn deleted the fix/1198-useRouter-stable branch July 15, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Router.replace from createLocalizedPathnamesNavigation causes infinite render
1 participant
@amannn