Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make oe in SRAMResource optional. #27

Closed
nmigen-issue-migration opened this issue Aug 4, 2019 · 2 comments
Closed

Make oe in SRAMResource optional. #27

nmigen-issue-migration opened this issue Aug 4, 2019 · 2 comments

Comments

@nmigen-issue-migration
Copy link

Issue by cr1901
Sunday Aug 04, 2019 at 13:18 GMT
Originally opened as m-labs/nmigen-boards#26

As requested. This is a breaking change because the order of arguments to SRAMResource changed by making oe optional.

cr1901 included the following code: https://github.com/m-labs/nmigen-boards/pull/26/commits
@nmigen-issue-migration
Copy link
Author

Comment by whitequark
Sunday Aug 04, 2019 at 13:21 GMT

It is not breaking, all *Resource arguments are keyword-only.

@nmigen-issue-migration
Copy link
Author

Comment by whitequark
Sunday Aug 04, 2019 at 13:22 GMT

And you don't even need to reorder them in the definition, def x(*, a=None, b): pass is valid Python.

rroohhh pushed a commit to rroohhh/nmigen-boards that referenced this issue Aug 4, 2020
@whitequark
back.pysim: check for a clock being added twice.
066dd79 
This commit adds a best-effort error for a common mistake of adding
a clock driving the same domain twice, such as a result of
a copy-paste error.

Fixes amaranth-lang#27.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nmigen-issue-migration