Added support for the Cyclone IV de0_nano board #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitequark
reviewed
Nov 24, 2020
nmigen_boards/de0_nano.py
Outdated
| Resource("clk50", 0, Pins("R8", dir="i"), | ||
| Clock(50e6), Attrs(io_standard="3.3-V LVTTL")), | ||
|
|
||
| Resource("i2c_flash", 0, |
There was a problem hiding this comment.
Should this be using I2CResources?
There was a problem hiding this comment.
no idea, would that be easier? It's a normal I2C interface to a 256x8 eeprom
whitequark
reviewed
Nov 24, 2020
nmigen_boards/de0_nano.py
Outdated
| Attrs(io_standard="3.3-V LVTTL") | ||
| ), | ||
|
|
||
| Resource("ADC", 0, |
There was a problem hiding this comment.
Could you link to the datasheet of the ADC please?
There was a problem hiding this comment.
https://www.ti.com/lit/ds/symlink/adc128s022.pdf looks like it's just an SPI interface. Should this be using SPIResources instead?
There was a problem hiding this comment.
modified to use an SPIResource using the ULX3S board file as an example
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.