Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for the Cyclone IV de0_nano board #113

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

benx45h
Copy link

@benx45h benx45h commented Sep 15, 2020

No description provided.

Resource("clk50", 0, Pins("R8", dir="i"),
Clock(50e6), Attrs(io_standard="3.3-V LVTTL")),

Resource("i2c_flash", 0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be using I2CResources?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea, would that be easier? It's a normal I2C interface to a 256x8 eeprom

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Attrs(io_standard="3.3-V LVTTL")
),

Resource("ADC", 0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you link to the datasheet of the ADC please?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.ti.com/lit/ds/symlink/adc128s022.pdf looks like it's just an SPI interface. Should this be using SPIResources instead?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modified to use an SPIResource using the ULX3S board file as an example

Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments.

@Freax13 Freax13 mentioned this pull request Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants