-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for the Cyclone IV de0_nano board #113
base: main
Are you sure you want to change the base?
Conversation
nmigen_boards/de0_nano.py
Outdated
Resource("clk50", 0, Pins("R8", dir="i"), | ||
Clock(50e6), Attrs(io_standard="3.3-V LVTTL")), | ||
|
||
Resource("i2c_flash", 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be using I2CResources
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no idea, would that be easier? It's a normal I2C interface to a 256x8 eeprom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
nmigen_boards/de0_nano.py
Outdated
Attrs(io_standard="3.3-V LVTTL") | ||
), | ||
|
||
Resource("ADC", 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you link to the datasheet of the ADC please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://www.ti.com/lit/ds/symlink/adc128s022.pdf looks like it's just an SPI interface. Should this be using SPIResources instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modified to use an SPIResource using the ULX3S board file as an example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments.
No description provided.