Is there any reason to keep xxx.submodules?

[nmigen-issue-migration]

Issue by mithro
Tuesday Dec 18, 2018 at 00:37 GMT
Originally opened as m-labs/nmigen#10

---

A huge number of issues in the old migen are caused by forgetting to assign something to xxx.submodules.

Is there any reason that we can't do something like this?

class Module:
    def __setattr__(self, k, v):
        if isinstance(v, Module):
           self.add_module(k, v)
        object.__setattr__(self, k, v)

[nmigen-issue-migration]

Comment by whitequark
Tuesday Dec 18, 2018 at 00:38 GMT

---

You do not inherit from Module in nMigen.

[nmigen-issue-migration]

Comment by whitequark
Tuesday Dec 18, 2018 at 00:52 GMT

---

And incidentally the reason you don't is this.

[nmigen-issue-migration]

Comment by whitequark
Tuesday Dec 18, 2018 at 00:57 GMT

---

Also, see #3--in nMigen forgetting to add a submodule will be a hard error, though I'm not yet sure exactly how this will be detected.