Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use something better than path= in Interface()/Signature.create() #909

Closed
whitequark opened this issue Sep 13, 2023 · 2 comments
Closed

Use something better than path= in Interface()/Signature.create() #909

whitequark opened this issue Sep 13, 2023 · 2 comments
Labels
improvement
Milestone
0.4

Comments

@whitequark
Copy link
Member

See the discussion in amaranth-lang/amaranth-soc#49.

This needs to be done before 0.4 since this would be a breaking change otherwise.
@whitequark whitequark added this to the 0.4 milestone Sep 13, 2023
@whitequark
Copy link
Member Author

We have discussed this issue on the 2023-12-04 weekly meeting. We unanimously decided that path= is a perfectly fine name, and no change is necessary.

@jfng I take it this decision extends to Amaranth SoC?

@whitequark whitequark closed this as not planned Won't fix, can't repro, duplicate, stale Dec 4, 2023
jfng added a commit to jfng/amaranth-soc that referenced this issue Dec 4, 2023
@jfng
memory: use path= instead of name= in ResourceInfo().
e944e4c 
See amaranth-lang/amaranth#909.
@jfng jfng mentioned this issue Dec 4, 2023
Merged
jfng added a commit to jfng/amaranth-soc that referenced this issue Dec 4, 2023
@jfng
csr.reg: use path instead of name in {FieldMap,FieldArray}.flatten().
003b90a 
See amaranth-lang/amaranth#909.
github-merge-queue bot pushed a commit to amaranth-lang/amaranth-soc that referenced this issue Dec 4, 2023
@jfng
memory: use path= instead of name= in ResourceInfo().
dff6abd 
See amaranth-lang/amaranth#909.
@jfng
Copy link
Member

jfng commented Dec 4, 2023

@jfng I take it this decision extends to Amaranth SoC?

Amaranth SoC will follow this convention going forward.

jfng added a commit to jfng/amaranth-soc that referenced this issue Dec 7, 2023
@jfng
csr.reg: use path instead of name in {FieldMap,FieldArray}.flatten().
3204e89 
See amaranth-lang/amaranth#909.
jfng added a commit to jfng/amaranth-soc that referenced this issue Dec 15, 2023
@jfng
csr.reg: use path instead of name in {FieldMap,FieldArray}.flatten().
4a1a2a5 
See amaranth-lang/amaranth#909.
jfng added a commit to jfng/amaranth-soc that referenced this issue Jan 19, 2024
@jfng
csr.reg: use path instead of name in {FieldMap,FieldArray}.flatten().
4b467cd 
See amaranth-lang/amaranth#909.
jfng added a commit to jfng/amaranth-soc that referenced this issue Feb 8, 2024
@jfng
csr.reg: use path instead of name in {FieldMap,FieldArray}.flatten().
306535f 
See amaranth-lang/amaranth#909.
jfng added a commit to jfng/amaranth-soc that referenced this issue Feb 9, 2024
@jfng
csr.reg: use path instead of name in {FieldMap,FieldArray}.flatten().
24953e1 
See amaranth-lang/amaranth#909.
github-merge-queue bot pushed a commit to amaranth-lang/amaranth-soc that referenced this issue Feb 9, 2024
@jfng
csr.reg: use path instead of name in {FieldMap,FieldArray}.flatten().
c29726d 
See amaranth-lang/amaranth#909.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Milestone
0.4
Development

No branches or pull requests
2 participants
@whitequark @jfng