Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RFC 45: Move hdl.Memory to lib.Memory. #1142

Merged
merged 1 commit into from Feb 19, 2024

Conversation

wanda-phi
Copy link
Member

@wanda-phi wanda-phi commented Feb 14, 2024

Fixes #216.

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (6d65dc1) 85.61% compared to head (93554fd) 85.87%.

Files Patch % Lines
amaranth/lib/memory.py 99.15% 1 Missing and 1 partial ⚠️
amaranth/hdl/_mem.py 95.65% 1 Missing ⚠️
amaranth/sim/pysim.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1142      +/-   ##
==========================================
+ Coverage   85.61%   85.87%   +0.26%     
==========================================
  Files          42       43       +1     
  Lines        8433     8675     +242     
  Branches     1998     2065      +67     
==========================================
+ Hits         7220     7450     +230     
- Misses       1016     1024       +8     
- Partials      197      201       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we decide to get rid of MemoryIdentity in the end?

amaranth/lib/memory.py Outdated Show resolved Hide resolved
amaranth/lib/memory.py Outdated Show resolved Hide resolved
amaranth/lib/memory.py Outdated Show resolved Hide resolved
@wanda-phi
Copy link
Member Author

Did we decide to get rid of MemoryIdentity in the end?

I ended up including it, since this allows us to recognize memories of all kinds (old and new) as "something that has an _identity that is MemoryInstance" in the simulator, avoiding a dependency.

Still not sure if this is the way to go.

Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you back out the docs rst file? I'd like to improve these before publishing, but I don't want to block the PR on that.

@wanda-phi
Copy link
Member Author

Can you back out the docs rst file? I'd like to improve these before publishing, but I don't want to block the PR on that.

Done

Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@whitequark whitequark added this pull request to the merge queue Feb 19, 2024
Merged via the queue into amaranth-lang:main with commit 890e099 Feb 19, 2024
16 checks passed
@wanda-phi wanda-phi deleted the lib-memory branch February 19, 2024 22:42
@whitequark whitequark added this to the 0.5 milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Memory port transparency model is flawed
2 participants