Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

back.rtlil: set read port init to all-x. #1353

Merged
merged 1 commit into from
May 9, 2024

Conversation

wanda-phi
Copy link
Member

This is an unfortunate necessity needed to fix memory inference regressions introduced when we switched to using v2 cells. A better approach, compatible with RFC 54, will need to be figured out for Amaranth 0.6.

Fixes #1011.

This is an unfortunate necessity needed to fix memory inference regressions
introduced when we switched to using v2 cells. A better approach, compatible
with RFC 54, will need to be figured out for Amaranth 0.6.

Fixes amaranth-lang#1011.
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@whitequark whitequark added this pull request to the merge queue May 9, 2024
Merged via the queue into amaranth-lang:main with commit 1d2b9c3 May 9, 2024
19 checks passed
@wanda-phi wanda-phi deleted the mem-init-x branch May 9, 2024 02:49
@whitequark whitequark modified the milestones: 0.6, 0.5 May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Inferring True Dual-Port BRAMs with the new IR on Series 7 and ECP5
2 participants