Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor.xilinx: Add support for more parts when using Symbiflow. #736

Merged
merged 4 commits into from Jan 23, 2023

Conversation

bl0x
Copy link
Contributor

@bl0x bl0x commented Jan 16, 2023

Adds support for parts used in Digilent CMOD boards.

amaranth/vendor/xilinx.py Outdated Show resolved Hide resolved
amaranth/vendor/xilinx.py Outdated Show resolved Hide resolved
amaranth/vendor/xilinx.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2023

Codecov Report

Merging #736 (fffd24e) into main (de6b693) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head fffd24e differs from pull request most recent head a9a6c49. Consider uploading reports for the commit a9a6c49 to get more accurate results

@@            Coverage Diff             @@
##             main     #736      +/-   ##
==========================================
- Coverage   81.10%   81.07%   -0.04%     
==========================================
  Files          49       49              
  Lines        6543     6543              
  Branches     1571     1571              
==========================================
- Hits         5307     5305       -2     
  Misses       1041     1041              
- Partials      195      197       +2     
Impacted Files Coverage Δ
amaranth/_toolchain/cxx.py 95.23% <0.00%> (-4.77%) ⬇️
amaranth/build/run.py 21.73% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bl0x bl0x force-pushed the xilinx-symbiflow-more-parts branch from ef25a15 to 338cd33 Compare January 17, 2023 01:21
amaranth/vendor/xilinx.py Outdated Show resolved Hide resolved
whitequark
whitequark previously approved these changes Jan 23, 2023
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bl0x
Copy link
Contributor Author

bl0x commented Jan 23, 2023

Not sure, if rebasing to main is needed? It does mess with the history of the PR.

@whitequark
Copy link
Member

Not sure, if rebasing to main is needed? It does mess with the history of the PR.

I don't tend to keep track of history, so it's fine. I am also going to squash on my side before merging since this is a simple PR, but for more complex I would ask to rebase and squash into self-contained changes.

@bl0x
Copy link
Contributor Author

bl0x commented Jan 23, 2023

Got it.

@whitequark whitequark merged commit 64b96e1 into amaranth-lang:main Jan 23, 2023
@whitequark
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants