Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hdl.ast: fix range handling in Shape.cast. #804

Merged
merged 2 commits into from
Jun 7, 2023

Conversation

mwkmwkmwk
Copy link
Contributor

Fixes #803.

@whitequark whitequark added this to the 0.4 milestone Jun 7, 2023
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whitequark whitequark enabled auto-merge (rebase) June 7, 2023 12:09
@whitequark whitequark disabled auto-merge June 7, 2023 12:14
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #804 (a86e392) into main (a6e33ab) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #804   +/-   ##
=======================================
  Coverage   82.04%   82.04%           
=======================================
  Files          50       50           
  Lines        6869     6869           
  Branches     1672     1672           
=======================================
  Hits         5636     5636           
+ Misses       1037     1036    -1     
- Partials      196      197    +1     
Impacted Files Coverage Δ
amaranth/hdl/ast.py 89.50% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@whitequark whitequark added this pull request to the merge queue Jun 7, 2023
Merged via the queue into amaranth-lang:main with commit c798446 Jun 7, 2023
10 of 11 checks passed
@mwkmwkmwk mwkmwkmwk deleted the range-fix branch June 7, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Wrong shape computed for range(0, 10, 3)
2 participants