Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hdl.ast: fix shape for subtraction. #814

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

mwkmwkmwk
Copy link
Contributor

Fixes #813.

Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whitequark whitequark enabled auto-merge June 7, 2023 12:32
@whitequark whitequark added this pull request to the merge queue Jun 7, 2023
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #814 (e793fed) into main (656db31) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #814      +/-   ##
==========================================
+ Coverage   82.04%   82.11%   +0.07%     
==========================================
  Files          50       50              
  Lines        6867     6872       +5     
  Branches     1670     1673       +3     
==========================================
+ Hits         5634     5643       +9     
+ Misses       1037     1034       -3     
+ Partials      196      195       -1     
Impacted Files Coverage Δ
amaranth/hdl/ast.py 89.53% <100.00%> (+0.05%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Merged via the queue into amaranth-lang:main with commit 1d5e090 Jun 7, 2023
10 of 11 checks passed
@mwkmwkmwk mwkmwkmwk deleted the subtract-fix branch June 7, 2023 12:40
@whitequark
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Subtract of unsigned Values should have signed shape
2 participants